Page MenuHomePhabricator

Only load ogvjs if native playback is not supported
Closed, ResolvedPublicBUG REPORT

Description

For several reasons we would always load ogvjs if the browser you were using did not support vp9.

However in testing I noticed that this introduces a huge delay in loading basic mp3 audio clips with videojs, which is actually a pretty common use case, as we have way more audio clips than video clips.

It think we therefore should evaluate for each specific media element wether or not native playback of that set of sources is supported and only if NOT supported, then we should load ogvjs. That way the most common case of mp3s becomes much faster, and only when something actually requires it, we would have to load ogvjs.

This might require some extra promise guarding and expanding the functionality in OgvJsSupport lib

Event Timeline

TheDJ triaged this task as Low priority.
TheDJ moved this task from Backlog to Active on the VideoJS player board.

Change 783409 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] Allow OgvJsSupport to check a specific element

https://gerrit.wikimedia.org/r/783409

Next patch is to use this function, but it might require making infuse a promise, so i'm working on a separate patch for that.

Change 783457 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] Conditionally load ogvjs

https://gerrit.wikimedia.org/r/783457

Change 783409 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Allow OgvJsSupport to check a specific element

https://gerrit.wikimedia.org/r/783409

Change 783457 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Conditionally load ogvjs

https://gerrit.wikimedia.org/r/783457

Test wiki on Patch demo by TheDJ using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/7991d8b67f/w/