Page MenuHomePhabricator
Create Task
Maniphest T306254

MOBILE FUNCTION VIEW: edit button moves below function definition inputs and outputs
Closed, ResolvedPublic
Actions

Description

When in mobile view, the "edit" button next to function definition should be moved below the list of inputs/outputs and the copy should be changed from "edit" to "edit definition"

Screen Shot 2022-04-15 at 11.24.30 AM.png (742×1 px, 48 KB)

Details

SubjectRepoBranchLines +/-
change edit button positon and allow function definition item to be hiddenmediawiki/extensions/WikiLambdamaster+165 -113
Customize query in gerrit

Related Objects
Search...

Event Timeline

• JKieserman created this task.Apr 15 2022, 3:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2022, 3:25 PM
Jdforrester-WMF moved this task from Incoming to Ready: G4. Function view on the Abstract Wikipedia team (Phase θ – Throttling) board.Apr 19 2022, 4:32 PM
Jdforrester-WMF added a parent task: T306451: Adjust the function view to be mobile-friendly as well.Apr 19 2022, 4:58 PM
• AdesojiThisDot claimed this task.Apr 25 2022, 12:15 PM
• AdesojiThisDot moved this task from Ready: G4. Function view to In progress on the Abstract Wikipedia team (Phase θ – Throttling) board.Apr 25 2022, 2:58 PM
gerritbot added a comment.Jun 22 2022, 10:44 AM

Change 807506 had a related patch set uploaded (by AdesojiThisDot; author: AdesojiThisDot):

[mediawiki/extensions/WikiLambda@master] change edit button positon and allow function definition item to be hidden

https://gerrit.wikimedia.org/r/807506

gerritbot added a project: Patch-For-Review.Jun 22 2022, 10:44 AM
• AdesojiThisDot moved this task from In progress to Ready: G10. Function calls UX on the Abstract Wikipedia team (Phase θ – Throttling) board.Jun 27 2022, 2:58 PM
gerritbot added a comment.Jun 30 2022, 4:25 PM

Change 807506 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] change edit button positon and allow function definition item to be hidden

https://gerrit.wikimedia.org/r/807506

Maintenance_bot removed a project: Patch-For-Review.Jun 30 2022, 4:31 PM
• AdesojiThisDot moved this task from Ready: G10. Function calls UX to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.Jul 5 2022, 7:26 AM
gengh closed this task as Resolved.Jul 5 2022, 3:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL