Remove unused TimedMediaHandler messages
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Amire80
	Apr 17 2022, 8:01 AM

Description

Several i18n messages in TimedMediaHandler appear to be unused. I discovered it as I was doing some informal auditing of Extensions used by Wikimedia in translatewiki and noticed that some TimedMediaHandler messages were documented as "May unused" (sic) by @Umherirrender in qqq.

I ran git grep and here's what I found:

These messages don't appear anywhere outside json files:

mwe-embedplayer-loading_plugin
mwe-embedplayer-select_playback
mwe-embedplayer-link_back
mwe-embedplayer-error_swap_vid
mwe-embedplayer-add_to_end_of_sequence
mwe-embedplayer-missing_video_stream
mwe-embedplayer-next_clip_msg
mwe-embedplayer-prev_clip_msg
mwe-embedplayer-current_clip_msg
mwe-embedplayer-download_segment
mwe-embedplayer-download_right_click
mwe-embedplayer-download_clip
mwe-embedplayer-clip_linkback
mwe-embedplayer-video_credits
mwe-embedplayer-no-video_credits
mwe-embedplayer-read_before_embed
mwe-embedplayer-related_videos
mwe-embedplayer-missing-source

These are mentioned in the code, but I couldn't find where exactly. If they can actually be seen by users, it would be great to document them properly in qqq. If they are not actually seen, the messages and the corresponding code must be removed:

mwe-embedplayer-download_text
mwe-embedplayer-about-library
mwe-embedplayer-kaltura-platform-title

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/TimedMediaHandler	master	+0 -54	Remove unused messages
	translatewiki	master	+1 -1	Move TimedMediaHandler EmbedPlayer to Wikimedia - Legacy

Customize query in gerrit

Related Objects

Mentioned Here: T248418: Roll out videojs as the only video/audio player on all Wikimedia wikis
T224429: Hunt and remove unused i18n messages in mediawiki core

Event Timeline

Amire80 created this task.Apr 17 2022, 8:01 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2022, 8:01 AM

Amire80 updated the task description. (Show Details)Apr 17 2022, 8:08 AM

Change 783433 had a related patch set uploaded (by Amire80; author: Amire80):

[mediawiki/extensions/TimedMediaHandler@master] Remove unused messages

https://gerrit.wikimedia.org/r/783433

gerritbot added a project: Patch-For-Review.Apr 17 2022, 8:13 AM

DJ might know better but also I want to mention we are soon dropping kultura (in a month or so) and you can remove waay more messages because of that.

In T306302#7859942, @Ladsgroup wrote:

DJ might know better but also I want to mention we are soon dropping kultura (in a month or so) and you can remove waay more messages because of that.

Oh, interesting. I was always confused about VideoJS, "New media player", MWEmbed, etc. It's a process that that has been going on for a while.

Which messages are Kaltura? Those under i18n/EmbedPlayer? Or something else?

If you can point me to the files, I'll move them to "Legacy" on translatewiki ASAP.

Can't say for sure but by glancing over the code, yes. All of i18n/EmbedPlayer can be removed \o/ If you want to follow the progress, you can subscribe to T248418: Roll out videojs as the only video/audio player on all Wikimedia wikis