Page MenuHomePhabricator

"Changes made in edit" field not shown on AbuseFilter designed for flow
Open, Needs TriagePublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Imagine an abusefilter for flow filter group set, and it match action like edit-header or create-header etc.
  • Try to trigger this filter (an example on mediawikiwiki, this filter will block IP user from editing board description)
  • View abuselog

What happens?:
We know for traditional filter (in "default" filter group), there will be a "Changes made in edit" field at the top of an abuselog, if corresponding is designed for "edit" action

image.png (348×935 px, 55 KB)

However, for a flow filter, there is no such field in abuselog. Instead, we have to find what is added in edit_diff or added_lines field.

image.png (626×959 px, 68 KB)

What should have happened instead?:
Flow filter should also show "Changes made in edit" field.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

The relevant code checks that the action is "edit", and nothing else. In the past, that code was changed a few times due to corrupted blobs in the database (an issue that is now fixed). Instead, I think we could show the diff iff old_wikitext and new_wikitext are set. It may hide the diff for older rows with missing data, but I assume it's still worthwhile.