Can the tester describe the steps they took to make a test donation? If they were using a custom link, can you share it here?

Looping in @RKumar_WMF who was coordinating the payments testing. Rakhi, could you please see David's question above? Thank you!

Credit Card: https://payments.wikimedia.org/index.php?title=Special:AstropayGateway&appeal=JimmyQuote&payment_method=cc&recurring=&uselang=es&language=es&currency=PEN&amount=7&country=PE&ffname=astropay-pe&utm_campaign=internal_test

The above link I had shared with the tester. The tester will not be able to share the steps.

Weren't banners going to send the language code as es-419? That should get the right TY email. We don't currently have any logic to map a list of countries to es-419 in payments-wiki.

@Pcoombe Do you happen to have an older test banner for LATAM that this can be tested with? The local testers are having trouble getting the full experience here and payments wiki can't replicate the whole thing.

Yes, the banners will automatically change the uselang passed to paymentswiki from es to es-419 for the following countries: AR, CL, CO, MX, PE, UY, US. Also from pt to pt-br for Brazil. Code doing this is here: https://meta.wikimedia.org/wiki/MediaWiki:FundraisingBanners/CoreJS-2018.js#L-66

Hot off the press here's one of the es Latin America banners for the upcoming pre-test: https://es.wikipedia.org/w/index.php?title=NASA&banner=B2122_0511_esLA_dsk_p1_lg_twin1&country=PE

Thanks @Pcoombe !!!

@RKumar_WMF can the local tester try again?

CID: 54914851 tried, the donation went to Ingenico instead of dLocal. Also the Thank You email sender is still Maryana. please see below:

The link used was same as given in this phab: https://es.wikipedia.org/w/index.php?title=NASA&banner=B2122_0511_esLA_dsk_p1_lg_twin1&country=PE

Oh right, using dLocal is still waiting on T303207: Make dlocal default for PE UY

@RKumar_WMF This task is just talking about the TY email language. Did the donor receive the esMX version?

The email will still be signed by Jimmy but sent from Maryana until new translations come in. Also Peter is right, dlocal is not default yet. but neither of these should block you form verifying that you get the esMX version of the email.

Rakhi please feel free to share with me the tester's thank you email copy, and I can decipher it is esMX or esES. Thank you!

@CDenes_WMF - sent over email the Thank you email from tester.

Thank you Rakhi. The Email sent is still in esES (not esMX).
However, I went to production testmeister and sent myself a copy of esES and a copy of esMX and the esMX is using the same copy as esES. Here are the links to the templates that Tomasz shared with me, that show esES copy and the esMX copy, and how they are different:
esES template
esMX template

So there is a discrepancy between what is in the esMX template and what is in the esMX testmeister email

There is no way to tell if this is a bug until the esMX email text is changed. There may not be a bug here. Fr-tech can't help at the moment.

@TSkaff as fyi

Hi David! Could you please clarify what you mean by "until the esMX email text is changed"?

In T306356#7888248, @CDenes_WMF wrote:

Thank you Rakhi. The Email sent is still in esES (not esMX).
However, I went to production testmeister and sent myself a copy of esES and a copy of esMX and the esMX is using the same copy as esES. Here are the links to the templates that Tomasz shared with me, that show esES copy and the esMX copy, and how they are different:
esES template
esMX template

So there is a discrepancy between what is in the esMX template and what is in the esMX testmeister email

@CDenes_WMF you said yourself that the text is identical. We can't verify that there is a bug here if the text is identical. This should be relayed to anyone in charge of translating and updating text. Please go look at the emails in the Civi ui and check if they are identical there too. If they are identical in all these locations, we can't tell if there is a bug here.

Hello David and everyone,

The new version of the Thank You emails for Spanish (Latin America) is updated in CiviCRM messageTemplates and show Maryana as signee.

They are not updated for "Spanish; Castilian (Spain)" and show Jimmy as signee.

1. I have checked via testmeister with es_MX and it sends me the old template with Jimmy.

2. I have made a manual check via a civi record of a contact, with Spanish (Latin America) in Summary::Preferred Language, and it sends me the new template with Maryana.

3. I had a look at the record of the tester (CID=54911284) and the Preferred Language that is there is es_PE, which seems to make sense since the country is Peru.

4. So I had a more thorough check via a civi record on all relevant Spanish language code/countries that are part of our Latin America fundraising campaigns and it sends me the old template with Jimmy for all the below language codes:

a. es_PE (Peru)
b. es_AR (Argentina)
c. es_CL (Chile)
d. es_CO (Colombia)
e. es_UY (Uruguay)
f. es_419

g. There's no es_MX (Mexico) in "Preferred Language" in Summary in Civi as a choice (same thing in messageTemplates::add translation), and I suppose it has been renamed to Spanish (Latin America), the URL for the messageTemplate for Spanish (Latin America) ending with "es_MX" (https://civicrm.wikimedia.org/civicrm/admin/messageTemplates?reset=1#/edit?id=321&lang=es_MX)?

The only language code that is sending me the new template with Maryana as a signee is Spanish (Latin America).

5. Summary:

We have es and es_MX in testmeister, and es_MX in testmeister is sending us the old template.
We have in Civi records Preferred Language category as well as in the language choices for messageTemplates::add translation the following language codes: es_PE (Peru), es_AR (Argentina), es_CL (Chile), es_CO (Colombia), es_UY (Uruguay) and es_419 and Spanish (Latin America): this one is the only one to pull out the new template.

I hope this helps, maybe hopping on a call could be useful to clarify?

Hi @DStrine, apologies if I was unclear. The text is identical in testmeister but it is *Not* identical (i.e. it is different) in the Civi templates, and it should be different (as the translations are not the same) . Please see my previous comment which states that the translations are different in Civi and includes the links to the civi templates:

"Here are the links to the templates that Tomasz shared with me, that show esES copy and the esMX copy, and how they are different:
esES template
esMX template

So there is a discrepancy between what is in the esMX template and what is in the esMX testmeister email"

This bug is kind of growing beyond the original scope. I'm going to send an email on this. But we need to have clear steps to reproduce a bug and you need to show me the end result you saw and what you expected to see. And if this is just copy issues within specific TY emails, the team drafting the TY emails should troubleshoot this first.

@RKumar_WMF I have not seen any evidence that donors are receiving incorrect emails. If you can't provide this I'm going to decline this task.

To @CDenes_WMF and others on this task looking at testmeister. That sounds like a separate bug. Please write that up clearly describing which emails don't match up with the templates in civi.

Thank you, David! Replies in-line:

But we need to have clear steps to reproduce a bug and you need to show me the end result you saw and what you expected to see.

What we saw: LATAM test donor received the Spanish-SPAIN copy instead of the Spanish-LATAM copy (I repeat: yes they are different)
What we expected to see: LATAM test donor received the Spanish-LATAM copy

"if this is just copy issues within specific TY emails, the team drafting the TY emails should troubleshoot this first."

^ This is not a copy issue within specific TY emails. The copy is correct (and different) between Spanish-LATAM and Spanish-SPAIN, and it is correct in the respective Civi templates (which I linked above). The tester is receiving the incorrect copy.

To @CDenes_WMF and others on this task looking at testmeister. That sounds like a separate bug. Please write that up clearly describing which emails don't match up with the templates in civi.

I shared my Testmeister investigation to try to help identify what the issue is here. I thought it was related, but per your request, I will create a separate bug.

thanks @CDenes_WMF

I recognise that @RKumar_WMF sent you the Spanish-SPAIN copy I just don't know how the tester got this email.

Hi - I sent the below link to the tester to make a test donation. After completing the donation, the tester received the TY email that she sent to me and I forwarded the same to @CDenes_WMF . So I the tester received the Spanish-SPAIN copy instead of LATAM copy.

https://es.wikipedia.org/w/index.php?title=NASA&banner=B2122_0511_esLA_dsk_p1_lg_twin1&country=PE

@RKumar_WMF Thanks! I'm having trouble finding it in the logs - the only PE donation attempts I can find in May with that banner in the utm_source are incomplete, so wouldn't have gotten any TY mail.

Can you send us the tester's email address? To avoid posting it publicly, you can just email it to fr-tech@wikimedia.org.

The test donations were made in March and April. CID: 54914851 and 54911284.

@Ejegg This task was created on April 18th so I assume it would be a donation before that date.

Both CIDs have donations from before this task. @RKumar_WMF could you tell us the date the donor tested? Maybe the april 7th donation on CID 54914851 ?

Both contributions on CID: 54914851 looks like they got the LATAM email template.

CID 54911284 has one contribution and it too looks like it got the LATAM email.

Im basing this off of the fact the LATAM email starts with ¡Hola and the valencian starts with Benvolgut/Benvolguda

For easy reference the LATAM template is here:
https://civicrm.wikimedia.org/civicrm/admin/messageTemplates?reset=1#/edit?id=321&lang=es_MX

The valencian is here:
https://civicrm.wikimedia.org/civicrm/admin/messageTemplates?reset=1#/edit?id=321&lang=ca_ES

If the donor can tell us which of these donations got the wrong email that would help. I'm still not seeing a bug here.

Change 790726 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Set Latin American Spanish as default Spanish locale

https://gerrit.wikimedia.org/r/790726

Hi @DStrine ! RE:

Im basing this off of the fact the LATAM email starts with ¡Hola and the valencian starts with Benvolgut/Benvolguda

The mix up is not between esLATAM and Catalan, it is between esLATAM and esES.

You should be comparing esES and esMX (not caES and esMX).

Both esES and esMX start with Hola, so you need to look at the following sentence of the email body in order to differentiate between the two.

Yeah @Ejegg corrected me on that. I still don't see a bug here with initial donations if the person is using the right links in the right country.

Elliott set the default email template to esMX so that if there is a mixup or the system needs to fall back to something it will fall back to esMX at least for now as we prep for the LATAM countries.

There is possibly an edge case where someone located in Spain moves to a LATAM country they may still get the esES version. That seems to have been a possibility for a long time and is very much an edge case (tracking this with T308043). But that shouldn't stop testing or a campaign.

I'm declaring bankruptcy on this task. If the original tester wants to donate using a different email address or you get another donor and see a bug, please file a separate task with steps taken, expected result, actual result. Please sync up with @XenoRyet for tips on testing.

Thanks for the update David. The LATAM pre-test is running today. So we can investigate incoming donations and check that they are getting the esLATAM copy.

@TomaszGorski would you be able to look into that and check one donor per country ? David, feel free to close this -- I will open a separate bug if we find an issue.

Thank you!
Camille