Page MenuHomePhabricator

[A/B test] Empty space on the left with Vector-2022 in control group
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:

betacommons empty space.png (644×1 px, 69 KB)

What should have happened instead?:
The content should be center aligned, rather than a gap on the left

Developer notes

There is an A/B test enabled on the beta cluster, but the control group is not being styled appropriately. The HTML for the new table of contents if present in the sidebar, but hidden, presumably this is why.

QA Results - Beta

ACStatusDetails
1T306366#7882704

QA Results - Prod

ACStatusDetails
1T306366#7891513

Event Timeline

Jdlrobson renamed this task from Empty space on the left with Vector-2022, __NOTOC__ removes it to [A/B test] Empty space on the left with Vector-2022 in control group.Apr 18 2022, 11:17 PM
Jdlrobson updated the task description. (Show Details)

Change 784318 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@master] Fix empty space on left when bucketed in the control/unsampled group

https://gerrit.wikimedia.org/r/784318

Change 784318 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix empty space on left when bucketed in the control/unsampled group

https://gerrit.wikimedia.org/r/784318

Test Result - Beta

Status: ✅ PASS
Environment: betacommons
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps:

Visit https://commons.wikimedia.beta.wmflabs.org/w/index.php?title=User_talk:AJ-test&oldid=277819&useskin=vector-2022
Make sure you are bucketed in the control group (skin-vector-toc-experiment class should be present on the body tag)
✅ AC1: The content should be center aligned, rather than a gap on the left

Screen Shot 2022-04-26 at 2.24.47 PM.png (1×1 px, 191 KB)

Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: commons
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps:

Visit https://commons.wikimedia.beta.wmflabs.org/w/index.php?title=User_talk:AJ-test&oldid=277819&useskin=vector-2022
Make sure you are bucketed in the control group (skin-vector-toc-experiment class should be present on the body tag)
✅ AC1: The content should be center aligned, rather than a gap on the left

Screen Shot 2022-04-29 at 7.29.50 AM.png (1×2 px, 601 KB)

Confirming gap does not appear on euwiki:

Screen Shot 2022-05-02 at 12.26.55 PM.png (1×1 px, 380 KB)