Page MenuHomePhabricator

In the function editor, setting/editing a name doesn't trigger the Save/Publish enabled/disabled state until you click out, but it should
Closed, ResolvedPublic

Event Timeline

Is this the expected behavior? My understanding is that a name is not required for save/publish, so that shouldn't have any impact on those buttons

Do you mean the z-object editor? I believe the function-editor Publish button is reactive as soon as you start typing in any box. The "labels" boxes on the z-object editor however are not, but that appears to be true for the value appearing in the "Current ZObject" tree on the right too - it only appears once you click out of the box. I'm assuming the preferred behavior is for it to appear as it is typed? I can look into that.

Change 864825 had a related patch set uploaded (by Dani DW; author: Dani DW):

[mediawiki/extensions/WikiLambda@master] In ZString use the onInput event rather than the onChange event - this is triggered on every letter type rather than on focus out.

https://gerrit.wikimedia.org/r/864825

In T306379#8448158, @Ddwaal-WMF wrote:

Do you mean the z-object editor? I believe the function-editor Publish button is reactive as soon as you start typing in any box. The "labels" boxes on the z-object editor however are not, but that appears to be true for the value appearing in the "Current ZObject" tree on the right too - it only appears once you click out of the box. I'm assuming the preferred behavior is for it to appear as it is typed? I can look into that.

Yeah, since filing the behaviour of the function editor has been adjusted so this only applies to the fallback editor right now. :-) Thanks!

Change 864825 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] In ZString use the onInput event rather than the onChange event - this is triggered on every letter type rather than on focus out.

https://gerrit.wikimedia.org/r/864825

Change 868121 had a related patch set uploaded (by Dani DW; author: Dani DW):

[mediawiki/extensions/WikiLambda@master] Change the ZMonolingual input to use @input rather than @onchange to update the zobject immediately.

https://gerrit.wikimedia.org/r/868121

Change 868121 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Change the ZMonolingual input to use @input rather than @onchange to update the zobject immediately.

https://gerrit.wikimedia.org/r/868121