Page MenuHomePhabricator

New Topic Tool doesn't always clean up properly after itself
Closed, ResolvedPublic


Steps to reproduce:

  1. Use Firefox (probably)
  2. Use the New Topic Tool to post a ==New section==
  3. See something weird (rarely)

After posting, the new section is displayed at what should be the end of the page, but parts of the DiscussionTools interface doesn't get removed, and the page contents get duplicated underneath the new section. In this screenshot, the ==Lead image== section is the new one, and it's at the end of the page ...even though it doesn't look like it on screen.

Screen Shot 2022-04-15 at 9.50.42 PM.png (1×1 px, 339 KB)

The resulting wikitext is good (diff for the edit showin in this screenshot), and reloading the page solves the display problem.

Event Timeline

I don't know why the new topic tool wouldn't be removed after posting – if you see this again, can you check browser console for errors?

But I can see why the contents of the page would be duplicated inside of it, we can at least fix this so that it's less confusing.

Change 784313 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Avoid duplicating page content if there are multiple .mw-parser-output elements

Change 784313 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Avoid duplicating page content if there are multiple .mw-parser-output elements

matmarex claimed this task.

Presumably no longer happens, but please reopen if it does.