Page MenuHomePhabricator
Create Task
Maniphest T306399

New topic not highlighted after being published on mobile with section collapsing
Closed, ResolvedPublic
Actions

Description

Behavior

  1. On a mobile device, visit: https://patchdemo.wmflabs.org/wikis/484c06ac07/wiki/Talk:DiscussionTools
  2. Tap Add topic
  3. Publish a new topic using the New Topic Tool
  4. Topic you drafted in "3." is published successfully

Actual

  1. ❗️ The topic that was published in "4." is NOT scrolled into view nor is it highlighted

Expected

  1. ✅ The topic that was published in "4." is scrolled into view and it is highlighted

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix highlighting and expanding of new topics on mobilemediawiki/extensions/DiscussionToolsmaster+35 -25
Customize query in gerrit

Event Timeline

ppelberg created this task.Apr 18 2022, 10:44 PM
ppelberg moved this task from Inbox to Ready to Be Worked On on the Editing-team (Kanban Board) board.
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.
Esanders removed a parent task: T305655: Create prototypes for usability testing of Usability Improvements (desktop + mobile).EditedApr 19 2022, 2:14 PM

This isn't related to the changes in the prototype patch, it has just never worked and can be seen on beta: https://simple.m.wikipedia.beta.wmflabs.org/wiki/Talk:France

Esanders renamed this task from New topic not highlighted after being published to New topic not highlighted after being published on mobile with section collapsing.Apr 19 2022, 2:22 PM
gerritbot added a comment.Apr 19 2022, 2:41 PM

Change 784271 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Fix highlighting of new topics on mobile

https://gerrit.wikimedia.org/r/784271

gerritbot added a project: Patch-For-Review.Apr 19 2022, 2:41 PM
Esanders moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.Apr 19 2022, 2:42 PM
Esanders removed subscribers: • KieranMcCann, Jdforrester-WMF, • Whatamidoing-WMF and 15 others.
gerritbot added a comment.Apr 19 2022, 7:10 PM

Change 784271 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix highlighting and expanding of new topics on mobile

https://gerrit.wikimedia.org/r/784271

Maintenance_bot removed a project: Patch-For-Review.Apr 19 2022, 7:30 PM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Apr 19 2022, 7:36 PM
matmarex added a project: Editing QA.
EAkinloose subscribed.Apr 29 2022, 10:30 PM

Newly published topic is scrolled into view and highlighted. See

Test.jpeg (2×1 px, 1 MB)

EAkinloose edited projects, added Verified; removed Editing QA.Apr 29 2022, 10:31 PM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
ppelberg closed this task as Resolved.May 7 2022, 1:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits