Page MenuHomePhabricator
Create Task
Maniphest T306403

Deprecate Skin::getAction
Closed, ResolvedPublic
Actions

Description

Skin::getAction is a wrapper

It's seldom used:
https://codesearch.wmcloud.org/skins/?q=getAction%5C(&i=nope&files=&excludeFiles=&repos=

We are trying to move away from Skin convenience functions that wrap functionality inside services so this one should be deprecated.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Deprecate Skin::getActionmediawiki/coremaster+6 -4
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Apr 18 2022, 11:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 18 2022, 11:03 PM
gerritbot added a comment.Apr 19 2022, 8:10 AM

Change 784092 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] Depreacte Skin::getAction

https://gerrit.wikimedia.org/r/784092

gerritbot added a project: Patch-For-Review.Apr 19 2022, 8:10 AM
gerritbot added a comment.Apr 19 2022, 6:11 PM

Change 784092 merged by jenkins-bot:

[mediawiki/core@master] Deprecate Skin::getAction

https://gerrit.wikimedia.org/r/784092

Maintenance_bot removed a project: Patch-For-Review.Apr 19 2022, 6:29 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.9; 2022-04-25).Apr 19 2022, 7:01 PM
Jdlrobson closed this task as Resolved.May 9 2022, 10:45 PM
Jdlrobson claimed this task.
Jdlrobson added a subscriber: Ammarpad.

THanks @Ammarpad for taking care of this one!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits