Page MenuHomePhabricator
Create Task
Maniphest T30643

Merge Serbian language variant conversion improvements to trunk
Closed, ResolvedPublic
Actions

Description

In my MediaWiki branch (files http://svn.mediawiki.org/viewvc/mediawiki/branches/nikola/phase3/languages/LanguageConverter.php and http://svn.mediawiki.org/viewvc/mediawiki/branches/nikola/phase3/languages/classes/LanguageSr.php ) I have introduced changes which tell MediaWiki not to convert Serbian text between variants if the conversion is not necessary (i.e. it won't convert Cyrillic to Cyrillic, or Latin to Latin). This should drastically reduce the need for -{}- tags, that users generally underuse. Please merge this to trunk, so that it may be deployed to Wikimedia projects. Nikerabbit seems to approve (see comments at http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85224#code-comments ) and LanguageConverter maintainers seem to have no problems with it.

Version: 1.18.x
Severity: normal

Details

Reference
bz28643

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:35 PM
• bzimport added projects: MW-1.19.0-release, MediaWiki-Language-converter.
• bzimport set Reference to bz28643.
Nikola_Smolenski created this task.Apr 21 2011, 1:40 PM
Catrope added a comment.Apr 21 2011, 1:44 PM

Is it just r85224 and its followup r85239 that need merging?

• demon added a comment.Apr 21 2011, 1:48 PM

And r85308, with the comment fix.

• demon added a comment.Apr 21 2011, 2:03 PM

Merged in r86623

Nikola_Smolenski added a comment.Aug 31 2011, 2:47 PM

Reopened since it got reverted in r90951. I will try to write the tests.

hashar added a comment.Oct 24 2011, 10:55 AM

Nikola > have you made any progress on writing tests? I can write them for you if you can explain me what is the expected behavior :-)

hashar added a comment.Oct 31 2011, 5:34 PM

Tests added in Nikola branch: r101369 . I have emailed him so he can review the tests and eventually add more.

Nikola_Smolenski added a comment.Nov 15 2011, 6:22 AM

Thank you so much hashar :) The tests test what they are supposed to test, and I have added one more (roman numerals) in r103131.

hashar added a comment.Nov 15 2011, 10:24 PM

Thanks to have taken sometime to review the tests. It is probably safer when a native speaker handle that sort of language issues. Kudos on the test addition!

I will merge the branch in trunk :-)

hashar added a comment.Nov 16 2011, 3:12 PM

LanguageSr improvement in /branches/nikola/phase3 got merged by r103327

It is too late for inclusion in 1.18 but will surely be able to deploy this on the live site with 1.19.

Winston_Sung moved this task from Backlog to Converter-specific on the MediaWiki-Language-converter board.Dec 27 2023, 6:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL