Page MenuHomePhabricator
Create Task
Maniphest T306508

ContentTranslation doesn't know that an article already exists in the Norwegian Bokmål Wikipedia
Open, MediumPublicBUG REPORT
Actions

Assigned To
santhosh
Authored By
jhsoby
Apr 20 2022, 11:15 AM
Tags
Referenced Files
F59012917: Screenshot_20250408_094618.png
Tue, Apr 8, 7:48 AM
F59012902: Screenshot_20250408_094326.png
Tue, Apr 8, 7:48 AM
F59012894: Screenshot_20250408_094126.png
Tue, Apr 8, 7:48 AM
F58865857: Screenshot_20250319_091542.png
Mar 19 2025, 8:18 AM
F58865840: Screenshot_20250319_091305.png
Mar 19 2025, 8:18 AM
F58680880: Screenshot_20250308_130438.png
Mar 8 2025, 12:05 PM
F58680594: Screenshot_20250308_130006.png
Mar 8 2025, 12:05 PM
F35845456: norsk_suggestion2.webm
Dec 8 2022, 4:49 AM
Subscribers
Aklapper
EChukwukere-WMF
GMikesell-WMF
jhsoby

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:

  • Many/most of the top suggestions already have articles in Norwegian Bokmål
  • Some examples from just now: World War I, Joseph Stalin, Elizabeth I, Georgia (country)

What should have happened instead?:

  • It should not suggest articles that already exist in the Norwegian Bokmål Wikipedia.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.: MediaWiki 1.39.0-wmf.7 (800f261), ContentTranslation 670863b

This is most likely yet another iteration of our no/nb problems. The Norwegian Bokmål Wikipedia is located at https://no.wikipedia.org/ and has the database name nowiki, but its language code is (correctly) set to nb. So what I guess CX is doing is to check whether an article exists in nbwiki on Wikidata, while in fact it should check whether the article exists in nowiki.

Details

SubjectRepoBranchLines +/-
Update recommendation-api to 2025-03-25-091801-productionoperations/deployment-chartsmaster+2 -2
Consider special language codes while checking for article existenceresearch/recommendation-apimaster+39 -2
nowiki: Use the 'no' domain code for getting translation suggestionsmediawiki/extensions/ContentTranslationmaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

jhsoby created this task.Apr 20 2022, 11:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2022, 11:15 AM
jhsoby mentioned this in T306509: ContentTranslation should not suggest the Main Page for translation.Apr 20 2022, 11:15 AM
Nikerabbit moved this task from Needs Triage to Bugs on the ContentTranslation board.Jun 6 2022, 11:47 AM
Nikerabbit added a project: Language-Team (Language-2022-April-June).
Pginer-WMF triaged this task as Medium priority.Jun 6 2022, 11:47 AM
Pginer-WMF edited projects, added Language-Team (Language-2022-July-September); removed Language-Team (Language-2022-April-June).Jul 4 2022, 10:58 AM
Pginer-WMF moved this task from Quarter Backlog to Priority: Unified Content & Section Translation on the Language-Team (Language-2022-July-September) board.Aug 1 2022, 2:23 PM
Pginer-WMF edited projects, added Language-Team (Language-2022-October-December); removed Language-Team (Language-2022-July-September).Oct 3 2022, 3:07 PM
Pginer-WMF moved this task from Quarter Backlog to Priority: Unified Content & Section Translation on the Language-Team (Language-2022-October-December) board.
gerritbot added a comment.Nov 8 2022, 9:01 AM

Change 854473 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] nowiki: Use the 'no' domain code for getting translation suggestions

https://gerrit.wikimedia.org/r/854473

gerritbot added a project: Patch-For-Review.Nov 8 2022, 9:01 AM
santhosh claimed this task.Nov 8 2022, 9:04 AM
santhosh moved this task from Priority: Unified Content & Section Translation to In Review on the Language-Team (Language-2022-October-December) board.Nov 8 2022, 9:33 AM
gerritbot added a comment.Nov 8 2022, 10:17 AM

Change 854473 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] nowiki: Use the 'no' domain code for getting translation suggestions

https://gerrit.wikimedia.org/r/854473

Maintenance_bot removed a project: Patch-For-Review.Nov 8 2022, 10:31 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 8 2022, 11:00 AM
jhsoby added a comment.Nov 8 2022, 11:30 AM

Thank you @santhosh!

ngkountas moved this task from In Review to Check after deployment on the Language-Team (Language-2022-October-December) board.Nov 11 2022, 11:41 AM
Nikerabbit moved this task from Check after deployment to Needs QA on the Language-Team (Language-2022-October-December) board.Nov 30 2022, 9:52 AM
EChukwukere-WMF subscribed.Dec 8 2022, 4:49 AM

Test status: QA PASS

EChukwukere-WMF moved this task from Needs QA to Done on the Language-Team (Language-2022-October-December) board.Dec 8 2022, 4:49 AM
Pginer-WMF closed this task as Resolved.Dec 9 2022, 11:57 AM
jhsoby reopened this task as Open.Mar 8 2025, 12:05 PM

I'm sorry, but this has started happening again (don't know when it started).

To reproduce:

My suggestions for translations from English to Norwegian Bokmål:

Screenshot_20250308_130006.png (1×1 px, 213 KB)

The list includes Greenland and (for reasons I don't quite understand) a bunch of actors; Greenland already has an article, of course, as do most of these actors.

  • When you click one of these to (try to) start translating, however, it warns you that the article already exists:

Screenshot_20250308_130438.png (219×714 px, 22 KB)

Text with yellow background = "This page already exists in Norwegian Bokmål"

jhsoby added a parent task: T85903: Resolve the issues with Norwegian macro language code in ContentTranslation (tracking).Mar 8 2025, 2:27 PM
jhsoby mentioned this in T388400: Minerva's language selector suggests translating an article into Norwegian Bokmål even though an article already exists.Mar 10 2025, 1:02 PM
santhosh added a comment.Mar 19 2025, 7:01 AM

@jhsoby I was testing this again, and I don't see the issue now.
More importantly, the CX dashboard's new version is coming up. It will replace the current dashboard.
The following URL can be used to access new dashboard.
You can access it in https://no.wikipedia.org/w/index.php?title=Special:ContentTranslation&unified-dashboard=1&filter-type=automatic&filter-id=previous-edits&active-list=draft&from=en&to=nb#/

Could you please help verify if no/nb related recurring issues are resolved there or not? Thanks in advance

jhsoby added a comment.EditedMar 19 2025, 8:18 AM

@santhosh It still happens to me, both in the old and new dashboards. Screenshots attached.
It is not as noticeable with the new dashboard, since it seems to give more varied suggestions.

Old dashboard

Screenshot_20250319_091305.png (770×1 px, 178 KB)

New dashboard

Screenshot_20250319_091542.png (916×1 px, 114 KB)

I had to refresh the suggestions a few times for the selection in the second screenshot to appear, but there we do have articles on both the first and the second of the three suggested articles.

A translation that was suggested to me (that I forgot to screenshot) was the article on Vladimir Putin. In the new dashboard, as opposed to the old, when I started translating it I didn't get a warning that the article existed. It let me start translating, and only when I went to publish did it warn me that I would be overwriting an existing article. This seems like a step back from the behaviour of the old dashboard, where at least it would warn me before I started translating.

gerritbot added a comment.Mar 19 2025, 10:07 AM

Change #1129205 had a related patch set uploaded (by Santhosh; author: Santhosh):

[research/recommendation-api@master] Consider special language codes while checking for article existence

https://gerrit.wikimedia.org/r/1129205

gerritbot added a project: Patch-For-Review.Mar 19 2025, 10:07 AM
santhosh added a comment.Mar 20 2025, 6:02 AM

. It let me start translating, and only when I went to publish did it warn me that I would be overwriting an existing article. This seems like a step back from the behaviour of the old dashboard, where at least it would warn me before I started translating.

This is being discussed at https://phabricator.wikimedia.org/T386895#10574040

gerritbot added a comment.Mar 20 2025, 1:19 PM

Change #1129205 merged by jenkins-bot:

[research/recommendation-api@master] Consider special language codes while checking for article existence

https://gerrit.wikimedia.org/r/1129205

Maintenance_bot removed a project: Patch-For-Review.Mar 20 2025, 1:31 PM
SBisson added a project: LPL Hypothesis.Mar 20 2025, 1:44 PM
SBisson moved this task from Backlog to Pending deployment on the LPL Hypothesis board.
gerritbot added a comment.Mar 26 2025, 3:56 AM

Change #1131128 had a related patch set uploaded (by KartikMistry; author: KartikMistry):

[operations/deployment-charts@master] Update recommendation-api to 2025-03-25-091801-production

https://gerrit.wikimedia.org/r/1131128

gerritbot added a project: Patch-For-Review.Mar 26 2025, 3:56 AM
gerritbot added a comment.Mar 26 2025, 5:00 AM

Change #1131128 merged by jenkins-bot:

[operations/deployment-charts@master] Update recommendation-api to 2025-03-25-091801-production

https://gerrit.wikimedia.org/r/1131128

Maintenance_bot removed a project: Patch-For-Review.Mar 26 2025, 5:30 AM
Stashbot added a comment.Mar 26 2025, 4:34 PM

Mentioned in SAL (#wikimedia-operations) [2025-03-26T16:34:43Z] <kart_> Updated recommendation-api-ng to 2025-03-25-091801-production (T306508)

SBisson moved this task from Pending deployment to Needs QA on the LPL Hypothesis board.Mar 26 2025, 4:36 PM
GMikesell-WMF subscribed.EditedMar 26 2025, 8:19 PM

@jhsoby The patch for this issue has been deployed. Could you please review it and confirm whether the fix works as expected? I saw this has been tested a couple of times, and it looks like you know more about where to test to see if this is ok now. Let us know if you encounter any further issues.

GMikesell-WMF added a comment.Mon, Apr 7, 3:01 PM

Hey @jhsoby! I'm following up as it's been a little while. The patch for this issue was deployed over a week ago, and we haven’t heard back if you came across anything else. We’ll go ahead and consider this resolved for now. If you run into any remaining issues or notice anything unexpected, feel free to reopen the task or comment and we’ll be happy to take another look. Thanks again!

GMikesell-WMF moved this task from Needs QA to Product Signoff on the LPL Hypothesis board.Mon, Apr 7, 3:02 PM
jhsoby added a comment.Tue, Apr 8, 7:48 AM

Hi @GMikesell-WMF! Sorry, I didn't have time to check before.

I did a check just now, and sadly the problem is not solved yet:

Screenshot_20250408_094126.png (568×1 px, 46 KB)

We already have an article on the Minority Report film: https://no.wikipedia.org/wiki/Minority_Report

Screenshot_20250408_094326.png (571×1 px, 60 KB)

We already have an article on donkeys ("Esel" from the screenshot): https://no.wikipedia.org/wiki/Tamesel

Screenshot_20250408_094618.png (570×1 px, 49 KB)

We already have an article on the Arab World ("الوطن العربي" from the screenshot): https://no.wikipedia.org/wiki/Den_arabiske_verden

PWaigi-WMF moved this task from Product Signoff to Needs QA on the LPL Hypothesis board.Fri, Apr 11, 4:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits