bad.json is an invalid JSON file
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Apr 20 2022, 1:50 PM

Description

I understand it's a test file, but need to decide how we want to handle it for release tooling purposes...

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Revert "make-release/scap_lint.py: Skip 'bad.json'"	mediawiki/tools/release	master	+0 -4
tests: Rename fixtures/bad.json	mediawiki/core	REL1_38	+1 -1
tests: Rename fixtures/bad.json	mediawiki/core	master	+1 -1
make-release/scap_lint.py: Skip 'bad.json'	mediawiki/tools/release	master	+4 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Reedy	T302893 Release MW 1.38.0
Resolved	Reedy	T302912 Release 1.38.0-rc.0
Resolved	Reedy	T306524 tests/phpunit/unit/includes/Settings/Source/fixtures/bad.json is an invalid JSON file

Event Timeline

Reedy created this task.Apr 20 2022, 1:50 PM

Reedy added a project: MediaWiki-Release-Tools.

I'm guessing Scap doesn't handle this, nor does it specifically care unless you try and sync that file (or something higher in the test tree that includes this). It'll work fine when syncing all the things

Change 784680 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/tools/release@master] Skip 'bad.json'

https://gerrit.wikimedia.org/r/784680

Change 784680 merged by jenkins-bot:

[mediawiki/tools/release@master] make-release/scap_lint.py: Skip 'bad.json'

https://gerrit.wikimedia.org/r/784680

Reedy closed this task as Resolved.Apr 20 2022, 2:02 PM

Reedy claimed this task.

Reedy triaged this task as High priority.

Can we rename the file so it doesn't have a .json extension? I think there is a reasonable expectation for things to be named *.json to actually be valid JSON.

Example: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/refs/heads/master/tests/phpunit/data/registration/notjson.txt