Mentor dashboard stopped updating
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

Set yourself as a (manual) mentor by adding your username to Progetto:Coordinamento/Accoglienza/Growth/Manuale
Open Special:MentorDashboard
Claim some mentees via [[Special:ClaimMentee]]: you can claim me (ValeJappo) if you wish, but remember to set the edit limit to at least 18000

What happens?:
Mentees are not updated, the list is blocked to 6 days ago

MentorDashboard_NoNewMenteesDisplayed (1×2 px, 380 KB)

What should have happened instead?:
The list should be updated with all the new mentees with edits

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
itwiki, same result with different devices. already tried refreshing / clearing cache

Details

	Subject	Repo	Branch	Lines +/-
	GlobalUserSelectQueryBuilder: Do not fatal when no users are returned	mediawiki/extensions/CentralAuth	wmf/1.39.0-wmf.8	+5 -0
	GlobalUserSelectQueryBuilder: Do not fatal when no users are returned	mediawiki/extensions/CentralAuth	master	+5 -0

Customize query in gerrit

Related Objects

Mentioned In: T307402: Maintenance scripts should consistently log errors
Mentioned Here: rECAUc4c4c3219ad6: GlobalUserSelectQueryBuilder: Do not fatal when no users are returned
T301910: Make it possible to check locked status for multiple users

Event Timeline

valcio created this task.Apr 20 2022, 3:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2022, 3:00 PM

@Urbanecm_WMF should this be in the current sprint? I moved it to upcoming work for now.

Definitely, thanks @mewoph for the ping! I'll check what's happening here.

I can confirm this by looking at the logs. This is what I can see for itwiki:

Apr 21 06:15:23 mwmaint1002 mediawiki_job_growthexperiments-updateMenteeData-s2[29270]: itwiki
Apr 21 06:15:23 mwmaint1002 mediawiki_job_growthexperiments-updateMenteeData-s2[29270]: -----------------------------------------------------------------
Apr 21 06:15:23 mwmaint1002 mediawiki_job_growthexperiments-updateMenteeData-s2[29270]: InvalidArgumentException from line 2675 of /srv/mediawiki/php-1.39.0-wmf.8/includes/libs/rdbms/database/Database.php: Wikimedia\Rdbms\Database::makeList: empty input for field actor_user
Apr 21 06:15:23 mwmaint1002 mediawiki_job_growthexperiments-updateMenteeData-s2[29270]: #0 /srv/mediawiki/php-1.39.0-wmf.8/includes/libs/rdbms/database/Database.php(2042): Wikimedia\Rdbms\Database->makeList(Array, 1)
Apr 21 06:15:23 mwmaint1002 mediawiki_job_growthexperiments-updateMenteeData-s2[29270]: #1 /srv/mediawiki/php-1.39.0-wmf.8/includes/libs/rdbms/database/DatabaseMysqlBase.php(1413): Wikimedia\Rdbms\Database->selectSQLText(Array, Array, Array, 'Wikimedia\\Rdbms...', Array, Array)
Apr 21 06:15:23 mwmaint1002 mediawiki_job_growthexperiments-updateMenteeData-s2[29270]: #2 /srv/mediawiki/php-1.39.0-wmf.8/includes/libs/rdbms/database/Database.php(1981): Wikimedia\Rdbms\DatabaseMysqlBase->selectSQLText(Array, Array, Array, 'Wikimedia\\Rdbms...', Array, Array)
Apr 21 06:15:23 mwmaint1002 mediawiki_job_growthexperiments-updateMenteeData-s2[29270]: #3 /srv/mediawiki/php-1.39.0-wmf.8/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->select(Array, Array, Array, 'Wikimedia\\Rdbms...', Array, Array)
Apr 21 06:15:23 mwmaint1002 mediawiki_job_growthexperiments-updateMenteeData-s2[29270]: #4 /srv/mediawiki/php-1.39.0-wmf.8/includes/libs/rdbms/database/DBConnRef.php(279): Wikimedia\Rdbms\DBConnRef->__call('select', Array)
Apr 21 06:15:23 mwmaint1002 mediawiki_job_growthexperiments-updateMenteeData-s2[29270]: #5 /srv/mediawiki/php-1.39.0-wmf.8/includes/libs/rdbms/querybuilder/SelectQueryBuilder.php(641): Wikimedia\Rdbms\DBConnRef->select(Array, Array, Array, 'Wikimedia\\Rdbms...', Array, Array)
Apr 21 06:15:23 mwmaint1002 mediawiki_job_growthexperiments-updateMenteeData-s2[29270]: #6 /srv/mediawiki/php-1.39.0-wmf.8/includes/user/UserSelectQueryBuilder.php(206): Wikimedia\Rdbms\SelectQueryBuilder->fetchResultSet()
Apr 21 06:15:23 mwmaint1002 mediawiki_job_growthexperiments-updateMenteeData-s2[29270]: #7 [internal function]: MediaWiki\User\UserSelectQueryBuilder->MediaWiki\User\{closure}()
Apr 21 06:15:23 mwmaint1002 mediawiki_job_growthexperiments-updateMenteeData-s2[29270]: #8 /srv/mediawiki/php-1.39.0-wmf.8/extensions/GrowthExperiments/includes/MentorDashboard/MenteeOverview/UncachedMenteeOverviewDataProvider.php(162): iterator_to_array(Object(Generator))
Apr 21 06:15:23 mwmaint1002 mediawiki_job_growthexperiments-updateMenteeData-s2[29270]: #9 /srv/mediawiki/php-1.39.0-wmf.8/extensions/GrowthExperiments/includes/MentorDashboard/MenteeOverview/UncachedMenteeOverviewDataProvider.php(184): GrowthExperiments\MentorDashboard\MenteeOverview\UncachedMenteeOverviewDataProvider->getLockedMenteesIds(Array)
Apr 21 06:15:23 mwmaint1002 mediawiki_job_growthexperiments-updateMenteeData-s2[29270]: #10 /srv/mediawiki/php-1.39.0-wmf.8/extensions/GrowthExperiments/includes/MentorDashboard/MenteeOverview/UncachedMenteeOverviewDataProvider.php(360): GrowthExperiments\MentorDashboard\MenteeOverview\UncachedMenteeOverviewDataProvider->getFilteredMenteesForMentor(Object(User))
Apr 21 06:15:23 mwmaint1002 mediawiki_job_growthexperiments-updateMenteeData-s2[29270]: #11 /srv/mediawiki/php-1.39.0-wmf.8/extensions/GrowthExperiments/includes/MentorDashboard/MenteeOverview/MenteeOverviewDataUpdater.php(95): GrowthExperiments\MentorDashboard\MenteeOverview\UncachedMenteeOverviewDataProvider->getFormattedDataForMentor(Object(User))
Apr 21 06:15:23 mwmaint1002 mediawiki_job_growthexperiments-updateMenteeData-s2[29270]: #12 /srv/mediawiki/php-1.39.0-wmf.8/extensions/GrowthExperiments/maintenance/updateMenteeData.php(123): GrowthExperiments\MentorDashboard\MenteeOverview\MenteeOverviewDataUpdater->updateDataForMentor(Object(User))
Apr 21 06:15:23 mwmaint1002 mediawiki_job_growthexperiments-updateMenteeData-s2[29270]: #13 /srv/mediawiki/php-1.39.0-wmf.8/maintenance/doMaintenance.php(114): GrowthExperiments\Maintenance\UpdateMenteeData->execute()
Apr 21 06:15:23 mwmaint1002 mediawiki_job_growthexperiments-updateMenteeData-s2[29270]: #14 /srv/mediawiki/php-1.39.0-wmf.8/extensions/GrowthExperiments/maintenance/updateMenteeData.php(189): require_once('/srv/mediawiki/...')
Apr 21 06:15:23 mwmaint1002 mediawiki_job_growthexperiments-updateMenteeData-s2[29270]: #15 /srv/mediawiki/multiversion/MWScript.php(116): require_once('/srv/mediawiki/...')
Apr 21 06:15:23 mwmaint1002 mediawiki_job_growthexperiments-updateMenteeData-s2[29270]: #16 {main}

Apparently, the update fails with InvalidArgumentException for some reason. According to the growthexperiments-mentor-dashboard-last-update preference, 2022-04-13T18:16:28 was the last time the update process successfully finished.

@ValeJappo, thanks for filling the task! I'll investigate this and hopefully I'll be able to fix this soon.

Change 785109 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/CentralAuth@master] GlobalUserSelectQueryBuilder: Do not fatal when no users are returned

https://gerrit.wikimedia.org/r/785109

gerritbot added a project: Patch-For-Review.Apr 21 2022, 7:03 AM

I found the issue. Caused by introducing GlobalUserSelectQueryBuilder as part of T301910. Uploaded a fix.

Urbanecm_WMF moved this task from Backlog to In review on the User-Urbanecm_WMF (Engineering) board.Apr 21 2022, 7:04 AM

Urbanecm_WMF renamed this task from Mentor dashboard stopped updating on itwiki to Mentor dashboard stopped updating.Apr 21 2022, 7:11 AM

Change 785109 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] GlobalUserSelectQueryBuilder: Do not fatal when no users are returned

https://gerrit.wikimedia.org/r/785109

Change 785207 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/CentralAuth@wmf/1.39.0-wmf.8] GlobalUserSelectQueryBuilder: Do not fatal when no users are returned

https://gerrit.wikimedia.org/r/785207

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.9; 2022-04-25).Apr 21 2022, 9:01 PM

Zabe updated the task description. (Show Details)Apr 21 2022, 9:17 PM

Change 785207 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@wmf/1.39.0-wmf.8] GlobalUserSelectQueryBuilder: Do not fatal when no users are returned

https://gerrit.wikimedia.org/r/785207

Mentioned in SAL (#wikimedia-operations) [2022-04-25T13:12:06Z] <urbanecm@deploy1002> Synchronized php-1.39.0-wmf.8/extensions/CentralAuth/includes/User/GlobalUserSelectQueryBuilder.php: c4c4c3219ad69705c83caa50754d95285c96f352: GlobalUserSelectQueryBuilder: Do not fatal when no users are returned (T306535) (duration: 00m 54s)

Hello @ValeJappo, fyi, I just deployed the fix to itwiki (and all other wikis). Within a couple of hours (max. 3 hours), your mentor dashboard should update again (as well as everyone else's). Please do not hesitate to let us know if it doesn't work for any reason.

Urbanecm_WMF closed this task as Resolved.Apr 25 2022, 1:15 PM

In T306535#7876802, @Urbanecm_WMF wrote:

Hello @ValeJappo, fyi, I just deployed the fix to itwiki. Within a couple of hours (max. 3 hours), your mentor dashboard should update again (as well as everyone else's). Please do not hesitate to let us know if it doesn't work for any reason.

Thanks! Have a nice day.

Maintenance_bot removed a project: Patch-For-Review.Apr 25 2022, 1:31 PM

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.8; 2022-04-18); removed MW-1.39-notes (1.39.0-wmf.9; 2022-04-25).Apr 25 2022, 2:00 PM

Tgr mentioned this in T307402: Maintenance scripts should consistently log errors.May 3 2022, 8:33 PM

	F35060145: MentorDashboard_NoNewMenteesDisplayed
	Apr 20 2022, 3:00 PM

Mentor dashboard stopped updatingClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

Mentor dashboard stopped updating
Closed, ResolvedPublicBUG REPORT
Actions