To solve the issues with errors on multiple location values we should:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Only use first wikidata query result for the same item | mediawiki/services/kartotherian | master | +3 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T67626 [Epic] Support for queries on-wiki (automated list generation) | |||
| Resolved | ECohen_WMDE | T188291 Display point features (coordinates) from the results of a SPARQL query on a map in Wikipedia | |||
| Resolved | None | T302297 Display geopoint SPARQL queries in a map in Wikipedia (GeoPoints) | |||
| Resolved | None | T307695 Display coordinate markers in Kartographer maps from QID | |||
| Resolved | thiemowmde | T306540 Handling of multiple location values from wikidata items | |||
| Resolved | WMDE-Fisch | T306543 Use first result value when multiple locations exist on a Wikidata item |
Change 785303 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):
[mediawiki/services/kartotherian@master] Only use first wikidata query result for the same item
To test this you could use
<mapframe latitude="41.671111" longitude="13.487222" zoom="10" width="400" height="400" align="center">
{
"type": "ExternalData",
"service": "geopoint",
"ids": "Q833129"
}
</mapframe>Q833129 currently has two locations ^^'
Change 785303 merged by jenkins-bot:
[mediawiki/services/kartotherian@master] Only use first wikidata query result for the same item
This is a great first step, but we might want to support the multiple coordinates by rendering them all. @Lucas_Werkmeister_WMDE shared a query which finds valid use cases, here. For example, the first result is a lake with portions in two countries, and coordinates are given for the center of each portion.
As far as I understand this ticket it was about improving the situation from "the code can't deal with multiple coordinates, gives up and the user sees nothing" to "show something, whatever it is". We did that. It's ready to be demoed.
I suggest to make the next step an incremental one that's as simple as the previous one: Just show all coordinates. Everything else (e.g. making the duplicates distinguishable, adding labels, possibly show error messages) can be explored and discussed after this is done.
@thiemowmde Ok thanks for the clarification. Maybe the title just needs a re-naming then to reflect what the task ended up being about. I won't decline it :)
I suggest to make the next step an incremental one that's as simple as the previous one: Just show all coordinates. Everything else (e.g. making the duplicates distinguishable, adding labels, possibly show error messages) can be explored and discussed after this is done.
Makes sense to me.