Page MenuHomePhabricator

[Story Viewer] White page elements are invisible against a white picture background
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
EUdoh-WMF
Apr 20 2022, 8:37 PM
Referenced Files
F35139295: image.png
May 13 2022, 10:15 PM
F35095847: Text box shadow - When creating story.png
May 3 2022, 10:42 AM
F35095793: Slice 1.png
May 3 2022, 10:42 AM
F35095853: Text box shadow - When Viewing story.png
May 3 2022, 10:42 AM
F35060931: image.png
Apr 21 2022, 5:13 AM
F35060568: image.png
Apr 20 2022, 8:37 PM

Description

List of steps to reproduce

  1. Create a story using pictures that are white at the upper half of them.
  2. Publish the story and view the story frames.
  3. Look out for the (X) icon at the top-right of the frame and the story page numbers.

What happens?:
The white X icon and page numbers are not visible against a white background

What should have happened instead?:
There should be a border or shadow around these white components. They should be visible against a white background.

image.png (1×638 px, 696 KB)
image.png (1×790 px, 507 KB)
Design details

Apply overlay & shadow related changes to the following parts of Wikistories.

Text box
Slice 1.png (814×437 px, 183 KB)
  • Apply shadow to the text box. This would make it visible against a white background.
In class .ext-wikistories-current-frame-textbox-select-cta

Modify following properties

From

border-radius: 10px;

To

border-radius: 2px;

From

background color: #fff

To

background: linear-gradient(0deg, #FFFFFF, #FFFFFF), #FFFFFF;

Add following property

box-shadow: 0px 2px 2px rgba(0, 0, 0, 0.25);

Apply overlay on story builder. This would make overlay icon visible against white background.

Overlay while creating story
Text box shadow - When creating story.png (780×360 px, 179 KB)
In class .ext-wikistories-storybuilder-story-topbar

Modify following property

From

height: 44px;

To

height: 140px;

From

background: linear-gradient(to bottom,rgba(0,0,0,0.5),rgba(255,255,255,0));

To

background: linear-gradient(180deg, rgba(0, 0, 0, 0.35) 0%, rgba(0, 0, 0, 0) 100%);

Apply overlay on story viewer, this would make icons and status bar visible against white background.

Overlay during story viewer
Text box shadow - When Viewing story.png (780×360 px, 197 KB)

Add following code to existing story viewer code.

height: 140px; 
background: linear-gradient(180deg, rgba(0, 0, 0, 0.35) 0%, rgba(0, 0, 0, 0) 100%);

Event Timeline

EUdoh-WMF renamed this task from [Story Viewer] The Close icon (X) is invisible against a white picture background to [Story Viewer] White page elements are invisible against a white picture background.Apr 21 2022, 5:13 AM
EUdoh-WMF updated the task description. (Show Details)
SBisson triaged this task as High priority.May 5 2022, 12:16 AM

Change 790300 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/Wikistories@master] White page elements are invisible against a white picture background

https://gerrit.wikimedia.org/r/790300

Change 790300 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] White page elements are invisible against a white picture background

https://gerrit.wikimedia.org/r/790300