Avoid unnormalized dbhost in "Table definition has changed, please retry transaction" message
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Krinkle
	Apr 21 2022, 3:38 PM

Description

Errors like these would be more useful if they do not leave the dbhost in the normalized message.

[{reqId}] {exception_url} Wikimedia\Rdbms\DBQueryError: Error 1412: Table definition has changed, please retry transaction (db1178)

	Subject	Repo	Branch	Lines +/-
	rdbms: Remove db name from error message	mediawiki/core	master	+1 -4

Mentioned Here: rMW59717e516156: Merging server feature from REL1_4
T306570: DBQueryError: Error 1412: Table definition has changed, please retry transaction (db1178) Function: LocalRepo::findFiles

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

It seems the server name is part of every errortext by DatabaseMysqlBase::lastError

Krinkle triaged this task as Low priority.Apr 25 2022, 7:23 PM

Change 787554 had a related patch set uploaded (by Krinkle; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Remove db name from error message

Change 787554 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Remove db name from error message

Ladsgroup closed this task as Resolved.May 6 2022, 6:12 AM

Ladsgroup claimed this task.

Ladsgroup added a project: DBA.

Ladsgroup moved this task from Triage to Done on the DBA board.