Page MenuHomePhabricator

Update QuickSurveys Initiation Impression value to correct field name
Open, Needs TriagePublic

Description

Currently the QuickSurveys initiation event that logs the editCountBucket is setting an incorrect field name causing a null value to be logged. The operation that sets editCountBucket needs to be changed so that is sets the correct field name in the dataset.

field name in dataset -

Screen Shot 2022-04-21 at 10.52.44 AM.png (224ร—258 px, 25 KB)

In the codebase we are assigning the edit count to a non-existent field name called userEditCountBucket when it
should be assigned to event.editcountbucket as per db schema above

Screen Shot 2022-04-21 at 10.53.09 AM.png (32ร—446 px, 8 KB)

This should resolve the issue blocking T303740

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptApr 21 2022, 3:51 PM
eigyan updated the task description. (Show Details)
eigyan updated the task description. (Show Details)
eigyan updated the task description. (Show Details)
eigyan updated the task description. (Show Details)

Nice catch, @eigyan! LMK if you need code review and/or getting the patch deployed (if you'd prefer it to be deployed ASAP).

Change 785878 had a related patch set uploaded (by Eigyan; author: Eigyan):

[mediawiki/extensions/QuickSurveys@master] QuickSurveys: Update QuickSurveys Initiation Impression value to correct field name

https://gerrit.wikimedia.org/r/785878

Nice catch, @eigyan! LMK if you need code review and/or getting the patch deployed (if you'd prefer it to be deployed ASAP).

@phuedx thank you! What a difference HUE access makes. I was able to quickly identify the mismatch ๐Ÿ’ฏ

Change 785878 merged by jenkins-bot:

[mediawiki/extensions/QuickSurveys@master] QuickSurveys: Update QuickSurveys Initiation Impression value to correct field name

https://gerrit.wikimedia.org/r/785878

jsn.sherman added a subscriber: Djackson-ctr.

Moving to QA with the assumption that @eigyan will be checking it on beta. I don't *think* there's anything for @Djackson-ctr to do here.

@jsn.sherman @Djackson-ctr I am moving this to Product Sign-off so that they can verify via a survey. We have validated that EventGate is marshaling the event.