Page MenuHomePhabricator
Create Task
Maniphest T306638

Update QuickSurveys Initiation Impression value to correct field name
Open, Needs TriagePublic
Actions

Description

Currently the QuickSurveys initiation event that logs the editCountBucket is setting an incorrect field name causing a null value to be logged. The operation that sets editCountBucket needs to be changed so that is sets the correct field name in the dataset.

field name in dataset -

Screen Shot 2022-04-21 at 10.52.44 AM.png (224×258 px, 25 KB)

In the codebase we are assigning the edit count to a non-existent field name called userEditCountBucket when it
should be assigned to event.editcountbucket as per db schema above

Screen Shot 2022-04-21 at 10.53.09 AM.png (32×446 px, 8 KB)

This should resolve the issue blocking T303740

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/QuickSurveysmaster+3 -3QuickSurveys: Update QuickSurveys Initiation Impression value to correct field name
Customize query in gerrit

Related Objects

Event Timeline

eigyan created this task.Apr 21 2022, 3:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 21 2022, 3:51 PM
eigyan added a project: WMF-Safety-Survey.Apr 21 2022, 3:51 PM
eigyan updated the task description. (Show Details)Apr 21 2022, 3:54 PM
eigyan updated the task description. (Show Details)
eigyan updated the task description. (Show Details)
eigyan updated the task description. (Show Details)
eigyan updated the task description. (Show Details)Apr 21 2022, 3:58 PM
eigyan updated the task description. (Show Details)
eigyan updated the task description. (Show Details)Apr 21 2022, 4:01 PM
eigyan moved this task from 🎬 Ready to 💻 In Progress on the Trust and Safety Tools Team Backlog (Kanban) board.Apr 21 2022, 5:39 PM
phuedx added a subscriber: phuedx.Apr 25 2022, 9:37 AM

Nice catch, @eigyan! LMK if you need code review and/or getting the patch deployed (if you'd prefer it to be deployed ASAP).

eigyan claimed this task.Apr 25 2022, 2:59 PM
gerritbot added a comment.Apr 25 2022, 3:59 PM

Change 785878 had a related patch set uploaded (by Eigyan; author: Eigyan):

[mediawiki/extensions/QuickSurveys@master] QuickSurveys: Update QuickSurveys Initiation Impression value to correct field name

https://gerrit.wikimedia.org/r/785878

gerritbot added a project: Patch-For-Review.Apr 25 2022, 3:59 PM
eigyan added a project: QuickSurveys.Apr 25 2022, 4:07 PM
eigyan added a comment.Apr 25 2022, 5:54 PM
In T306638#7876258, @phuedx wrote:

Nice catch, @eigyan! LMK if you need code review and/or getting the patch deployed (if you'd prefer it to be deployed ASAP).

@phuedx thank you! What a difference HUE access makes. I was able to quickly identify the mismatch 💯

eigyan moved this task from 💻 In Progress to 🔍 Review/Feedback on the Trust and Safety Tools Team Backlog (Kanban) board.Apr 26 2022, 6:04 PM
gerritbot added a comment.May 2 2022, 3:45 PM

Change 785878 merged by jenkins-bot:

[mediawiki/extensions/QuickSurveys@master] QuickSurveys: Update QuickSurveys Initiation Impression value to correct field name

https://gerrit.wikimedia.org/r/785878

jsn.sherman added a subscriber: jsn.sherman.May 2 2022, 3:46 PM

This is getting merged in now.

jsn.sherman moved this task from 🔍 Review/Feedback to 🐛 QA on the Trust and Safety Tools Team Backlog (Kanban) board.May 2 2022, 3:47 PM
jsn.sherman added a subscriber: Djackson-ctr.

Moving to QA with the assumption that @eigyan will be checking it on beta. I don't *think* there's anything for @Djackson-ctr to do here.

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.10; 2022-05-02).May 2 2022, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 2 2022, 4:31 PM
eigyan moved this task from 🐛 QA to 🤘 Product Sign-off on the Trust and Safety Tools Team Backlog (Kanban) board.May 2 2022, 6:11 PM
eigyan added a comment.May 2 2022, 6:20 PM

@jsn.sherman @Djackson-ctr I am moving this to Product Sign-off so that they can verify via a survey. We have validated that EventGate is marshaling the event.

phuedx moved this task from Backlog to Bugs on the QuickSurveys board.May 4 2022, 5:05 PM
eigyan mentioned this in T303740: Update QuickSurvey initiation to collect editCountBucket.May 12 2022, 3:27 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL