Page MenuHomePhabricator
Create Task
Maniphest T306662

Rely on core to render the user links overflow menu rather than handling it custom in SkinVector
Closed, ResolvedPublic
Actions

Description

Background

While building the user links feature Vector introduced UserLinks__more.mustache, which was used to render the menu contents for the user links outside of the user links dropdown. This approach requires custom template data to be defined and rendered in SkinVector.

We can simplify SkinVector by rearranging the template data from core in Hooks.php, similar to what we already do for the watchlist link.

AC

  • No visual changes
  • User links have the correct attributes and labels
  • Tests are added/updated

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove custom rendering of the user links overflow menu in favor of using 'vector-user-menu-overflow', a vector specific menu bucket in Hooks.phpmediawiki/skins/Vectormaster+131 -155
Customize query in gerrit

Event Timeline

bwang created this task.Apr 21 2022, 7:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 21 2022, 7:59 PM
gerritbot added a comment.Apr 21 2022, 7:59 PM

Change 784298 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Remove custom rendering of the user links overflow menu in favor of creating correct menu data in Hooks.php

https://gerrit.wikimedia.org/r/784298

gerritbot added a project: Patch-For-Review.Apr 21 2022, 7:59 PM
Jdlrobson moved this task from Needs triage to Technical on the Vector (legacy skin) board.Apr 25 2022, 9:32 PM
gerritbot added a comment.Apr 25 2022, 9:42 PM

Change 784298 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Remove custom rendering of the user links overflow menu in favor of creating correct menu data in Hooks.php Also fixes storybook for user links

https://gerrit.wikimedia.org/r/784298

Jdlrobson moved this task from Backlog to Vector code cleanup on the Web-Team-Backlog-Archived (Needs Prioritization (Tech)) board.Apr 25 2022, 10:13 PM
gerritbot added a comment.Aug 2 2022, 3:40 PM

Change 784298 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove custom rendering of the user links overflow menu in favor of using 'vector-user-menu-overflow', a vector specific menu bucket in Hooks.php

https://gerrit.wikimedia.org/r/784298

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 2 2022, 4:00 PM
bwang closed this task as Resolved.Aug 5 2022, 8:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits