Site reverts to English after selecting home icon
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	apaskulin
	Apr 21 2022, 11:54 PM

Description

Expected behavior

Selecting the Wikimedia logo from https://developer-portal.wmcloud.org/es/get-started/ should navigate to https://developer-portal.wmcloud.org/es/

Observed behavior

Selecting the Wikimedia logo from https://developer-portal.wmcloud.org/es/get-started/ navigates to https://developer-portal.wmcloud.org/

Details

	Subject	Repo	Branch	Lines +/-
	i18n: vary target url for logo nav by locale	wikimedia/developer-portal	main	+3 -0

Customize query in gerrit

Related Objects

Mentioned In: rWDPO78fa51d9fd9b: i18n: vary target url for logo nav by locale
T287501: Check RTL support on the developer portal

Event Timeline

apaskulin created this task.Apr 21 2022, 11:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 21 2022, 11:54 PM

@bd808, how difficult do you think this will be to fix?

apaskulin mentioned this in T287501: Check RTL support on the developer portal.Apr 21 2022, 11:55 PM

apaskulin moved this task from Inbox to Implementation on the Wikimedia-Developer-Portal board.

In T306672#7873034, @apaskulin wrote:

@bd808, how difficult do you think this will be to fix?

Good question. It might be as easy as adding code to our custom translation plugin to vary the site_url setting as we build each language variant. It should be reasonably easy to test that by modifying the localize_config method in TranslatePlugin.

It turns out that config.extra.homepage is what we need to vary. Patch incoming. :)

Change 785309 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[wikimedia/developer-portal@main] i18n: vary target url for logo nav by locale

https://gerrit.wikimedia.org/r/785309

gerritbot added a project: Patch-For-Review.Apr 22 2022, 3:52 PM

bd808 changed the task status from Open to In Progress.Apr 22 2022, 3:53 PM

bd808 claimed this task.

Restricted Application added a project: User-bd808. · View Herald TranscriptApr 22 2022, 3:53 PM

Change 785309 merged by jenkins-bot:

[wikimedia/developer-portal@main] i18n: vary target url for logo nav by locale

https://gerrit.wikimedia.org/r/785309

bd808 mentioned this in rWDPO78fa51d9fd9b: i18n: vary target url for logo nav by locale.Apr 26 2022, 3:19 AM

Maintenance_bot removed a project: Patch-For-Review.Apr 26 2022, 3:31 AM

Verified in production. Thank you!

bd808 added a project: Developer-Advocacy (Apr-Jun 2022).Jun 30 2022, 4:22 PM

Site reverts to English after selecting home iconClosed, ResolvedPublicBUG REPORTActions