Page MenuHomePhabricator

Python 3.5 is not able to solve circular imports like Python 3.6+ do
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

Add
from pywikibot.tools import deprecated_args
or any other import from tools to logging.py

Waht happens:*
https://integration.wikimedia.org/ci/job/pywikibot-core-tox-fasttest-py35-docker/10731/console

16:08:11 fasttest-py35 run-test: commands[0] | python -W error::UserWarning -m pwb generate_user_files -family:wikipedia -lang:test -v
16:08:11 [147] /src$ /src/.tox/fasttest-py35/bin/python -W error::UserWarning -m pwb generate_user_files -family:wikipedia -lang:test -v
16:08:12 Traceback (most recent call last):
16:08:12   File "/usr/lib/python3.5/runpy.py", line 193, in _run_module_as_main
16:08:12     "__main__", mod_spec)
16:08:12   File "/usr/lib/python3.5/runpy.py", line 85, in _run_code
16:08:12     exec(code, run_globals)
16:08:12   File "/src/pwb.py", line 272, in <module>
16:08:12     import pywikibot as pwb
16:08:12   File "/src/pywikibot/__init__.py", line 21, in <module>
16:08:12     from pywikibot import config as _config
16:08:12   File "/src/pywikibot/config.py", line 62, in <module>
16:08:12     from pywikibot.logging import error, output, warning
16:08:12   File "/src/pywikibot/logging.py", line 36, in <module>
16:08:12     from pywikibot.tools import deprecated_args
16:08:12   File "/src/pywikibot/tools/__init__.py", line 31, in <module>
16:08:12     import pywikibot.logging as _pylogging
16:08:12 AttributeError: module 'pywikibot' has no attribute 'logging'

Software version:
7.2.0.dev0

Event Timeline

Change 785386 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [bugfix] import pywikibot as a whole in tools/__init__.py

https://gerrit.wikimedia.org/r/785386

Xqt claimed this task.

Change 785386 merged by Xqt:

[pywikibot/core@master] [bugfix] import pywikibot as a whole in tools/__init__.py

https://gerrit.wikimedia.org/r/785386