Page MenuHomePhabricator
Create Task
Maniphest T306838

[API] New Vector search should not load wastefully large thumbnails
Closed, ResolvedPublic
Actions

Description

  1. Go to https://en.wikipedia.org/wiki/?useskin=vector-2022
  2. Emulate a slow connection in your browser (e.g. in Chrome, open the inspector, go to the Network tab, and change the "No throttling" dropdown to "Slow 3G")
  3. Type text into the search bar
  4. Watch thumbnail images load very slowly

Most of the reason that the images load slowly is that the connection is slow, but I think we could do (slightly) better here by loading smaller images.

Right now, the thumbnails are 200px in the longest dimension, and they're displayed as 36x36 squares with background-size: cover;, which causes the short side to be scaled down to 36px (and non-square images to be cropped). It would be better if we could ask for thumbnails at the size we intend to use (36px in the shortest dimension). It looks like the MediaWiki-REST-API may not currently support that, though.

Details

SubjectRepoBranchLines +/-
search: Use 60px for search thumbnailsmediawiki/coremaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

Catrope created this task.Apr 25 2022, 8:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 25 2022, 8:59 PM
Jdlrobson added projects: MediaWiki-REST-API, Platform Engineering, Desktop Improvements (Vector 2022).Apr 25 2022, 9:31 PM
Jdlrobson moved this task from Needs triage to Vector 2022 (tracking) on the Vector (legacy skin) board.
Jdlrobson added a project: Web-Team-Backlog.Apr 26 2022, 4:00 PM
Jdlrobson subscribed.

Vector blindly prints whatever images the API returns.

Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.Apr 27 2022, 4:50 PM
Jdlrobson moved this task from Incoming to Search on the Desktop Improvements (Vector 2022) board.Apr 27 2022, 5:16 PM
ovasileva triaged this task as Medium priority.May 3 2022, 1:14 PM
ovasileva moved this task from Not ready to estimate to Tracking on the Web-Team-Backlog board.
ovasileva mentioned this in T298898: [ToC] Collapse article sections at small resolutions.
lbowmaker subscribed.May 3 2022, 9:12 PM
alistair3149 subscribed.May 21 2022, 6:22 PM
Jdlrobson renamed this task from New Vector search should not load wastefully large thumbnails to [API] New Vector search should not load wastefully large thumbnails.Jun 8 2022, 3:57 PM
Jdlrobson moved this task from Search to Work with other teams on the Desktop Improvements (Vector 2022) board.
• alexhollender_WMF subscribed.Jul 22 2022, 2:18 PM
Jdlrobson mentioned this in T322621: Use standard thumbsizes in modern vector search.Nov 10 2022, 12:14 AM
Jdlrobson removed a project: Vector (legacy skin).

This is a bug for Vector 2022 not Vector legacy.

Ladsgroup subscribed.Nov 10 2022, 11:26 AM

See also: T322621: Use standard thumbsizes in modern vector search and T211661#8377883. Beside avoiding large thumbnails, it needs to load standard sizes to avoid cache fragmentation. Unfortunately I don't think we have a "really small" thumb size standard. People have converged on 40px in lots of places though. MediaWiki's small thumb sizes are 120px and 220px. This maybe a good time to decide on one and apply it everywhere (see T211661#8377883 for some examples of discrepancies in thumbsizes). And again, this is not related to design, you can load it with some size and show it differently.

Ladsgroup added a comment.Nov 15 2022, 1:06 PM

I suggest going with 60px (and then 120px for 2x), that's what I'm going for portals search.

gerritbot added a comment.Nov 15 2022, 4:56 PM

Change 857013 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] search: Use 60px for search thumbnails

https://gerrit.wikimedia.org/r/857013

gerritbot added a project: Patch-For-Review.Nov 15 2022, 4:56 PM
gerritbot added a comment.Nov 15 2022, 5:58 PM

Change 857013 merged by jenkins-bot:

[mediawiki/core@master] search: Use 60px for search thumbnails

https://gerrit.wikimedia.org/r/857013

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 15 2022, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 15 2022, 6:31 PM
TheDJ closed this task as Resolved.Mar 8 2023, 11:44 AM
TheDJ assigned this task to Ladsgroup.
TheDJ subscribed.

I think this can be closed ? Please reopen if not

TheDJ added a comment.Mar 8 2023, 12:17 PM

FYI, there is a list of all the various image widths used by tools at: https://www.mediawiki.org/wiki/Common_thumbnail_sizes#Applications

And yes, it is quite the mess.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL