The configurable demo for the TextInput component doesn't allow you to set the placeholder text, even though other demos below demonstrate placeholder usage. placeholder technically isn't a prop, it's an attribute that gets passed onto the <input>. We may want to distinguish this and put it in a separate "Attributes" section of the table, although I don't think that's super necessary (since the difference between a prop and an attribute isn't very noticeable to external users of the component).
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| docs: Allow configuring placeholder text for TextInput demo | DannyS712 | design/codex | main | +4 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T304062 docs: Codex doc site visual design/user experience improvements | |||
| Resolved | DannyS712 | T306856 Add placeholder attribute to configurable TextInput demo |
Event Timeline
Comment Actions
Change 786409 had a related patch set uploaded (by DannyS712; author: DannyS712):
[design/codex@main] docs: Allow configuring placeholder text for TextInput demo
Comment Actions
The text input demo already includes a note
This component will pass any HTML attributes applied to it, except for CSS class, to the <input> element within the component.
so it might make sense to list the HTML attributes separately, but for now just added as a normal prop, demo at
https://786409--wikimedia-codex.netlify.app/components/text-input.html#demos
Comment Actions
Change 786409 merged by jenkins-bot:
[design/codex@main] docs: Allow configuring placeholder text for TextInput demo
Comment Actions
@DannyS712 @Volker_E if this is in progress, could you please add the "In Progress" tag? If it's being worked on, then it would be appropriate to add to the current Sprint. Otherwise, we should add it to the "Up Next" column on our team board.
Comment Actions
I think this is done, not in progress, but I'm not going to mess with the DST tags for reasons I've explained at T295177#7879246