[Realtime Preview] Reload button should not display on top of error message
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Samwilson
	Apr 26 2022, 8:16 AM

Project Tags

Referenced Files

	F35091625: Screen Shot 2022-05-02 at 12.04.39 PM.png
	May 2 2022, 4:29 PM

	F35091618: Screen Shot 2022-05-02 at 12.03.51 PM.png
	May 2 2022, 4:26 PM

	F35091059: Screen Shot 2022-05-02 at 10.30.21 AM.png
	May 2 2022, 2:30 PM

	F35068280: Screenshot_20220426_161259.png
	Apr 26 2022, 8:16 AM

Subscribers

Aklapper

• imaigwilo

Samwilson

Description

The hovering reload button should not be shown while an error message is being shown, because the error message already has its own reload button.

Screenshot_20220426_161259.png (1,151×552 px, 23 KB)

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Realtime preview: don't show reload button on error message	Samwilson	mediawiki/extensions/WikiEditor	master	+5 -0

Customize query in gerrit

Event Timeline

Samwilson created this task.Apr 26 2022, 8:16 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2022, 8:16 AM

Change 786273 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiEditor@master] Realtime preview: don't show reload button on error message

https://gerrit.wikimedia.org/r/786273

gerritbot added a project: Patch-For-Review.Apr 26 2022, 8:24 AM

Samwilson renamed this task from Reload button should not display on top of error message to [Realtime Preview] Reload button should not display on top of error message.Apr 26 2022, 8:24 AM

Samwilson set the point value for this task to 1.

Samwilson edited projects, added: Community-Tech (CommTech-Sprint-24); removed: Patch-For-Review.

Samwilson moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-24) board.

Samwilson moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-24) board.Apr 27 2022, 11:02 AM

Change 786273 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Realtime preview: don't show reload button on error message

https://gerrit.wikimedia.org/r/786273

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.10; 2022-05-02).Apr 27 2022, 12:01 PM

Screen Shot 2022-05-02 at 10.30.21 AM.png (2,856×1,516 px, 583 KB)

Screen Shot 2022-05-02 at 12.03.51 PM.png (2,732×1,612 px, 626 KB)

• imaigwilo added a comment.May 2 2022, 4:29 PM

This comment was removed by • imaigwilo.

• imaigwilo moved this task from QA 🐛 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-24) board.May 2 2022, 4:36 PM

• NRodriguez closed this task as Resolved.May 4 2022, 5:42 PM

• JMcLeod_WMF moved this task from Product sign-off 🤘 to Done 🏁 on the Community-Tech (CommTech-Sprint-24) board.May 24 2022, 6:25 PM

[Realtime Preview] Reload button should not display on top of error messageClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Event Timeline

[Realtime Preview] Reload button should not display on top of error message
Closed, ResolvedPublic1 Estimated Story Points
Actions