Manual reload message bar disappears and content can be obscured when clicking internal links or collapsing content
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Apr 26 2022, 10:21 AM

Description

What is the problem?

When realtime preview is in manual-mode, if you click an internal link in the Preview the manual reload bar disappears.

It also happens when you collapse some content (like the Contents menu).

The whole div.ext-WikiEditor-realtimepreview-preview element appears to move upwards when I do so, obscuring the manual reload bar and sometimes other content depending on how far it has moved.

This can only be fixed by either reloading the page or pressing the reload shortcut key (alt+) on my machine).

If I do the latter, the manual reload bar does reappear but is still slightly obscured (see final screenshot).

When manual-mode is not on, clicking internal links and collapsing things appears to work fine.

Steps to reproduce problem

Go to a large page and open the source editor (e.g. https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Cat&action=edit, https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Polar_bear&action=edit)
Reload the page a few times until you see the reload bar (you might need to open devtools and throttle your connection)
In the right-hand preview pane, click on an internal link. For example, in https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Cat&action=edit click on any of the links inside the Contents menu (shown in the first screenshot). Or, collapse the Contents menu.

Expected behavior: The right hand preview pane scrolls down to the appropriate part of the document. The reload bar still appears.
Observed behavior: The reload bar disappears.

Environment

Browser: Firefox 91, Chromium 87
Wiki(s): https://en.wikipedia.beta.wmflabs.org MediaWiki 1.39.0-alpha (df2b1ee) 10:01, 26 April 2022.
Editor: WikiEditor 0.5.3 (45a8a07) 06:19, 25 April 2022.

Screenshots

Before:

After:

Position of div.ext-WikiEditor-realtimepreview-preview element:

manual_refresh_bar_disappear_html.png (662×1 px, 274 KB)

After pressing reload shortcut:

manual_refresh_bar_disappear_shortcut.png (720×1 px, 336 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Realtime Preview: fix display when toggling content in manual mode	mediawiki/extensions/WikiEditor	master	+0 -1

Customize query in gerrit

Related Objects

Mentioned In: T314467: Infinite horizontal scroll when using horizontal resizer
T313376: Preview pane overlaps outside its pane
Mentioned Here: rEWED9f3d4f0fd991: Realtime Preview: hide onboarding popup when screen is too narrow
T313376: Preview pane overlaps outside its pane
rEWED45a8a077b1c0: Localisation updates from https://translatewiki.net.
rMWdf2b1eef2a77: Merge "TempUser EditPage and permissions"

Event Timeline

dom_walden created this task.Apr 26 2022, 10:21 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2022, 10:21 AM

dom_walden renamed this task from Manual reload message bar disappears when clicking internal link to Manual reload message bar disappears when clicking internal links or collapsing content.Apr 26 2022, 10:41 AM

dom_walden updated the task description. (Show Details)

dom_walden renamed this task from Manual reload message bar disappears when clicking internal links or collapsing content to Manual reload message bar disappears and content can be obscured when clicking internal links or collapsing content.Apr 26 2022, 10:45 AM

dom_walden updated the task description. (Show Details)

• JMcLeod_WMF set the point value for this task to 2.Apr 27 2022, 11:41 AM

• JMcLeod_WMF moved this task from New & TBD Tickets to Up Next on the Community-Tech board.Jun 6 2022, 2:27 PM

• NRodriguez moved this task from Up Next to CommTech-Sprint-27 on the Community-Tech board.Jun 29 2022, 7:24 PM

• NRodriguez edited projects, added Community-Tech (CommTech-Sprint-27); removed Community-Tech.

HMonroy claimed this task.Jul 6 2022, 4:37 AM

HMonroy moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-27) board.

• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-28); removed Community-Tech (CommTech-Sprint-27).Jul 6 2022, 1:22 PM

• JMcLeod_WMF moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-28) board.Jul 6 2022, 1:26 PM

• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-29); removed Community-Tech (CommTech-Sprint-28).Jul 18 2022, 5:34 PM

• JMcLeod_WMF moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-29) board.Jul 18 2022, 5:38 PM

Change 815380 had a related patch set uploaded (by HMonroy; author: HMonroy):

[mediawiki/extensions/WikiEditor@master] Realtime Preview: fix display when toggling content in manual mode

https://gerrit.wikimedia.org/r/815380

gerritbot added a project: Patch-For-Review.Jul 19 2022, 8:44 PM

HMonroy moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-29) board.Jul 19 2022, 8:47 PM

Change 815380 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Realtime Preview: fix display when toggling content in manual mode

https://gerrit.wikimedia.org/r/815380

Maintenance_bot removed a project: Patch-For-Review.Jul 20 2022, 6:30 AM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.22; 2022-07-25).Jul 20 2022, 7:00 AM

Samwilson moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-29) board.Jul 20 2022, 9:47 AM

• NRodriguez moved this task from Backlog to 🌟Top Priority on the Realtime Preview board.Jul 20 2022, 12:05 PM

I am seeing some strange behaviour on beta. When I move the horizontal resizer to the right, I can keep going indefinitely.

horizontal_resize_overflow_2.gif (768×1 px, 3 MB)

I have only been able to reproduce this on beta, Vector 2022 with the left-hand menu open. I have reproduced it with the extension and the gadget.

I cannot reproduce this on plwiki or locally, so I don't know when this bug started to happen.

It seems similar to T313376, but I think it is different. @HMonroy @Samwilson

In T306877#8093774, @dom_walden wrote:

I am seeing some strange behaviour on beta. When I move the horizontal resizer to the right, I can keep going indefinitely.

…

It seems similar to T313376, but I think it is different. @HMonroy @Samwilson

I noticed the same. There's a max-width on the right panel, but the slider (or possibly something with flexbox) doesn't maintain that width within the confines of the WikiEditor viewport. I think this might be a JS issue with the slider. I'm looking into it for T313376.

Update: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiEditor/+/816013/1 seems to fix this.

In T306877#8095111, @MusikAnimal wrote:

I noticed the same. There's a max-width on the right panel, but the slider (or possibly something with flexbox) doesn't maintain that width within the confines of the WikiEditor viewport. I think this might be a JS issue with the slider. I'm looking into it for T313376.

Thanks. I will do more testing as part of that task.

With respect to the original bug, I haven't found any circumstance where the manual reload bar disappears or any of the Preview pane gets obscured when interacting with internal links or expand/collapse elements.

Test environment: https://en.wikipedia.beta.wmflabs.org WikiEditor 0.5.3 (9f3d4f0) 04:29, 21 July 2022 (latest tested).
Browsers: Firefox 91, Chromium 87.
Skins: Vector 2022, Vector 2010, Minerva, MonoBook, Timeless.

dom_walden mentioned this in T313376: Preview pane overlaps outside its pane.Jul 22 2022, 10:46 AM

• NRodriguez closed this task as Resolved.Jul 28 2022, 2:59 PM

• JMcLeod_WMF moved this task from Product sign-off 🤘 to Done 🏁 on the Community-Tech (CommTech-Sprint-29) board.Aug 2 2022, 2:55 PM

dom_walden mentioned this in T314467: Infinite horizontal scroll when using horizontal resizer.Aug 3 2022, 10:47 AM

	F35327540: horizontal_resize_overflow_2.gif
	Jul 21 2022, 9:28 AM

	F35068396: manual_refresh_bar_disappear_shortcut.png
	Apr 26 2022, 10:21 AM

	F35068393: manual_refresh_bar_disappear_html.png
	Apr 26 2022, 10:21 AM

	F35068388: manual_refresh_bar_disappear_before.png
	Apr 26 2022, 10:21 AM

	F35068390: manual_refresh_bar_disappear_after.png
	Apr 26 2022, 10:21 AM

Manual reload message bar disappears and content can be obscured when clicking internal links or collapsing contentClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions