Page MenuHomePhabricator
Create Task
Maniphest T306878

TypeError: Argument 1 passed to MediaWiki\Auth\Throttler::__construct() must be of the type array or null, integer given
Closed, ResolvedPublicBUG REPORT
Actions

Description

What is the problem?

Trying to edit a page on Beta, I get the error:

[YmfHz0ZwB5FpUmg-QzQZwAAAABE] /w/index.php?title=Cat&action=edit TypeError: Argument 1 passed to MediaWiki\Auth\Throttler::__construct() must be of the type array or null, integer given, called in /srv/mediawiki/php-master/includes/ServiceWiring.php on line 1839

Backtrace:

from /srv/mediawiki/php-master/includes/auth/Throttler.php(64)
#0 /srv/mediawiki/php-master/includes/ServiceWiring.php(1839): MediaWiki\Auth\Throttler->__construct(integer, array)
#1 /srv/mediawiki/php-master/vendor/wikimedia/services/src/ServiceContainer.php(447): Wikimedia\Services\ServiceContainer::{closure}(MediaWiki\MediaWikiServices)
#2 /srv/mediawiki/php-master/vendor/wikimedia/services/src/ServiceContainer.php(416): Wikimedia\Services\ServiceContainer->createService(string)
#3 /srv/mediawiki/php-master/includes/MediaWikiServices.php(301): Wikimedia\Services\ServiceContainer->getService(string)
#4 /srv/mediawiki/php-master/includes/MediaWikiServices.php(1742): MediaWiki\MediaWikiServices->getService(string)
#5 /srv/mediawiki/php-master/includes/EditPage.php(503): MediaWiki\MediaWikiServices->getTempUserCreator()
#6 /srv/mediawiki/php-master/includes/actions/EditAction.php(69): EditPage->__construct(Article)
#7 /srv/mediawiki/php-master/includes/MediaWiki.php(546): EditAction->show()
#8 /srv/mediawiki/php-master/includes/MediaWiki.php(322): MediaWiki->performAction(Article, Title)
#9 /srv/mediawiki/php-master/includes/MediaWiki.php(912): MediaWiki->performRequest()
#10 /srv/mediawiki/php-master/includes/MediaWiki.php(566): MediaWiki->main()
#11 /srv/mediawiki/php-master/index.php(50): MediaWiki->run()
#12 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#13 /srv/mediawiki/w/index.php(3): require(string)
#14 {main}
Steps to reproduce problem
  1. https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Cat&action=edit
Environment

Wiki(s): https://en.wikipedia.beta.wmflabs.org MediaWiki 1.39.0-alpha (df2b1ee) 10:01, 26 April 2022.
Editor: WikiEditor 0.5.3 (45a8a07) 06:19, 25 April 2022.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
TempUserCreator: Support old format of AccountCreationThrottleDaniel Kinzlermediawiki/coremaster+10 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

dom_walden created this task.Apr 26 2022, 10:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2022, 10:28 AM
dom_walden added a subscriber: tstarling.Apr 26 2022, 10:29 AM

@tstarling Could it possibly be due to this change? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/778684

AlexisJazz triaged this task as Unbreak Now! priority.Apr 26 2022, 11:46 AM
AlexisJazz merged a task: T306882: internal_api_error_TypeError (Argument 1 passed to MediaWiki\Auth\Throttler::__construct() must be of the type array or null).
AlexisJazz added subscribers: AlexisJazz, Urbanecm.

Changing priority per Urbanecm at duplicate task.

Urbanecm added a parent task: T305215: 1.39.0-wmf.9 deployment blockers.Apr 26 2022, 11:48 AM
AlexisJazz added projects: MediaWiki-Core-AuthManager, MediaWiki-libs-Services.Apr 26 2022, 11:50 AM
Urbanecm edited parent tasks, added: T305216: 1.39.0-wmf.10 deployment blockers; removed: T305215: 1.39.0-wmf.9 deployment blockers.Apr 26 2022, 12:07 PM
In T306878#7880198, @dom_walden wrote:

@tstarling Could it possibly be due to this change? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/778684

Looks like a correct guess to me (I can edit locally with this patch and its merged child reverted). The breaking patch is only in master, so re-classifying as wmf.10 blocker

Zabe subscribed.Apr 26 2022, 12:32 PM
Lucas_Werkmeister_WMDE lowered the priority of this task from Unbreak Now! to High.Apr 26 2022, 2:31 PM
Lucas_Werkmeister_WMDE subscribed.

The breaking patch is only in master, so re-classifying as wmf.10 blocker

Lowering priority slightly in that case, as it’s not a blocker for the current train.

Umherirrender merged a task: T306924: Related Articles and Popups selenium tests failing with error: "Argument 1 passed to MediaWiki\Auth\Throttler::__construct() must be of the type array or null".Apr 26 2022, 6:25 PM
Umherirrender added a subscriber: bwang.
daniel subscribed.Apr 26 2022, 6:31 PM

Looking...

daniel added a comment.Apr 26 2022, 6:38 PM

The instantiator callback for TempUserCreator creates a Throttler based on th AccountCreationThrottle setting, which it extepcts to be a list of throttle specs:

			new Throttler(
				$services->getMainConfig()->get( 'AccountCreationThrottle' ),
				[
					'type' => 'acctcreate',
					'cache' => $services->getLocalServerObjectCache()
				]
			)

Per MainConfigSchema, AccountCreationThrottle is a list of throttle specs:

	 $wgAccountCreationThrottle = [
	  // no more than 100 per month
	  [
	   'count' => 100,
	   'seconds' => 30*86400,
	  ],
	  // no more than 10 per day
	  [
	   'count' => 10,
	   'seconds' => 86400,
	  ],
	 ];

But InitialiseSettings.php has:
'wgAccountCreationThrottle' => [
'default' => 6,
'private' => 0, disable for wikis with sysop-only account creation
'fishbowl' => 0,
'eswikiquote' => 1, T230796
'hewikibooks' => 4,
'hewikinews' => 4,
'hewikiquote' => 4,
'hewikisource' => 4,
'hewiktionary' => 4,
],

This causes to be a single int, not a list of throttles.

ThrottlePreAuthenticationProvider has this workaround:

		// Handle old $wgAccountCreationThrottle format (number of attempts per 24 hours)
		if ( !is_array( $accountCreationThrottle ) ) {
			$accountCreationThrottle = [ [
				'count' => $accountCreationThrottle,
				'seconds' => 86400,
			] ];
		}

I suppose the instantiator callback for TempUserCreator needs to have the same workaround. Or we fix InitializeSettings.php.

gerritbot added a comment.Apr 26 2022, 6:43 PM

Change 786368 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] TempUserCreator: Support old format of AccountCreationThrottle

https://gerrit.wikimedia.org/r/786368

gerritbot added a project: Patch-For-Review.Apr 26 2022, 6:43 PM
gerritbot added a comment.Apr 26 2022, 8:38 PM

Change 786368 merged by jenkins-bot:

[mediawiki/core@master] TempUserCreator: Support old format of AccountCreationThrottle

https://gerrit.wikimedia.org/r/786368

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.10; 2022-05-02).Apr 26 2022, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 26 2022, 9:30 PM
Tgr subscribed.Apr 26 2022, 11:25 PM

Automatic code updates on Beta seem to be broken again :/

DannyS712 merged a task: T306946: Unable to edit any page on beta cluster.Apr 27 2022, 2:06 AM
DannyS712 added a subscriber: Stang.
Mainframe98 merged a task: T306938: Uploads stop after the first chunk.Apr 27 2022, 7:59 AM
Mainframe98 added a subscriber: Yann.
dom_walden added a comment.Apr 27 2022, 8:10 AM
In T306878#7882930, @Tgr wrote:

Automatic code updates on Beta seem to be broken again :/

They are working again now. Thanks for pointing this out.

tstarling closed this task as Resolved.Apr 27 2022, 11:40 PM
tstarling claimed this task.
Stang unsubscribed.Apr 27 2022, 11:41 PM
Umherirrender merged a task: T306938: Uploads stop after the first chunk.Aug 11 2025, 8:11 PM
Restricted Application added a project: MediaWiki-Core-Platform-Team. · View Herald TranscriptAug 11 2025, 8:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits