| • alexhollender_WMF | |
| Apr 26 2022, 12:34 PM |
| F35167567: Screen Shot 2022-05-22 at 6.22.32 PM.png | |
| May 23 2022, 1:24 AM |
| F35167566: Screen Shot 2022-05-22 at 6.19.57 PM.png | |
| May 23 2022, 1:24 AM |
| F35167565: Screen Shot 2022-05-22 at 6.21.13 PM.png | |
| May 23 2022, 1:24 AM |
| F35167562: Screen Shot 2022-05-22 at 6.18.06 PM.png | |
| May 23 2022, 1:23 AM |
| F35098914: Screen Shot 2022-05-03 at 4.15.47 PM.png | |
| May 3 2022, 9:18 PM |
| F35068722: Screen Shot 2022-04-26 at 11.47.45 AM.png | |
| Apr 26 2022, 3:48 PM |
| F35068518: toc corner issue and horizontal scroll.webm | |
| Apr 26 2022, 12:34 PM |
To view this issues visit: https://it.wikipedia.org/wiki/Discussioni_utente:Basilicofresco?oldid=127013187
https://phabricator.wikimedia.org/T306893#7948660
https://phabricator.wikimedia.org/T306893#7948662
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T306893#7948660 |
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T306893#7948662 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | ovasileva | T273473 [Epic] Improve the table of contents | |||
| Resolved | Jdlrobson | T306893 [ToC] Bottom fade issue |
This is because of this long title: https://it.wikipedia.org/wiki/Discussioni_utente:Basilicofresco#https://it.wikipedia.org/w/index.php?title=Ducato_di_Firenze&action=history
This is the same issue as T306913
@Jdlrobson I just deleted that <li> from the table of contents, but i'm still seeing the fade extend beyond the width of the table of contents:
not sure if that's a valid way to check it or not...
You have two issues here then :-) Let's remove "The ToC should never scroll horizontally" from this ticket and focus on the other issue.
This was likely introduced in the visual/layout changes patch. This can be fixed in 1 line by adding position: relative; to .sidebar-toc
Change 787048 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/skins/Vector@master] Fix TOC bottom fade
Change 787048 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Fix TOC bottom fade
Change 789210 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/skins/Vector@master] Fix TOC fadeout placement
Change 789263 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/skins/Vector@wmf/1.39.0-wmf.10] Fix TOC fadeout placement
Change 789263 merged by jenkins-bot:
[mediawiki/skins/Vector@wmf/1.39.0-wmf.10] Fix TOC fadeout placement
Mentioned in SAL (#wikimedia-operations) [2022-05-04T21:25:43Z] <cjming@deploy1002> Synchronized php-1.39.0-wmf.10/skins/Vector/resources/skins.vector.styles/components: Backport: [[gerrit:789263|Fix TOC fadeout placement (T306893)]] (duration: 00m 51s)
Change 789210 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Fix TOC fadeout placement
Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
✅ AC1: The fade at the bottom of the ToC should be contained to the width of the ToC
Status: ✅ PASS
Environment: enwiki, itwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
✅ AC1: The fade at the bottom of the ToC should be contained to the width of the ToC
