https://gerrit.wikimedia.org/r/c/css-sanitizer/+/786402/2/src/Objects/CSSObjectList.php
https://integration.wikimedia.org/ci/job/composer-package-php72-docker/20685/console
23:07:06 FILE: /src/src/Objects/CSSObjectList.php 23:07:06 ---------------------------------------------------------------------- 23:07:06 FOUND 1 ERROR AFFECTING 1 LINE 23:07:06 ---------------------------------------------------------------------- 23:07:06 172 | ERROR | Missing function doc comment 23:07:06 | | (MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic) 23:07:06 ----------------------------------------------------------------------
It doesn't seem to complain about
/** @inheritDoc */ #[\ReturnTypeWillChange] public function key() { return $this->offset; }
But it does about
/** @inheritDoc */ #[\ReturnTypeWillChange] public function offsetGet( $offset ) { if ( !is_numeric( $offset ) || (float)(int)$offset !== (float)$offset ) { throw new InvalidArgumentException( 'Offset must be an integer.' ); } if ( $offset < 0 || $offset > count( $this->objects ) ) { throw new OutOfBoundsException( 'Offset is out of range.' ); } return $this->objects[$offset]; }