In 1.39 skins following T62846 using SkinTemplate will trigger a deprecation notice Deprecated: Use of QuickTemplate::(get/html/text/haveData) with parameter bottomscripts` was deprecated in MediaWiki 1.39. [Called from QuickTemplate::get in /vagrant/mediawiki/includes/skins/QuickTemplate.php at line 144] in /vagrant/mediawiki/includes/debug/MWDebug.php on line 380`. On the long term this will ensure that all extension code is rendered by a skin and head tags are consistent.
There are no plans on the short term to break these skins, but a lot of skins are impacted and we should endeavor to fix as many of them as possible.
Any help is greatly appreciated and will be reviewed within 48hrs provided it's associated with this ticket.
The fix is relatively simple:
- Skins should add skin option bodyOnly: true to skin.json
- Skins should remove any echo statements that echo bottomscripts, headelement or getTrail
Examples:
- Timeless: https://gerrit.wikimedia.org/r/c/mediawiki/skins/Timeless/+/777826
- WikimediaApiPortal: https://gerrit.wikimedia.org/r/c/mediawiki/skins/WikimediaApiPortal/+/786397
Impacted skins
Last updated May 13th 2022:
- neptune
- material
- osmfoundation
- strapping (mediawiki-strapping)
- tyrian
- bluell
- pure
- hive
- p2wiki
- cosmos
- hassomecolours
- amethyst
- nimbus
- metrolook
- gamepress
- woogleshades
- poncho
- bluesky
- greystuff
- pivot
- foreground
- tweeki
- truglass
- gumaxdd
- splash
- wptouch
- deskmessmirrored
- bouquet
- dusk
- dusktodawn
- refreshed
- medik
- liberty
- darkvector
- aether https://invent.kde.org/websites/aether-mediawiki/-/merge_requests/4
- apex
- anisa
- erudite
- mask
- tempo
- wikimediaapiportal https://gerrit.wikimedia.org/r/c/mediawiki/skins/WikimediaApiPortal/+/786397
- webplatform
- jony
- modernskylight
- darkcosmos
- scratchwikiskin2
- onyx
- simpletext
- s2018
- monaco
- cavendish
- cavendish-brown
- cavendish-green
- mediawikibootstrap
- peruna
- collegeinsider
- cemublue
- library
- t29v7
- atlasmuseum
- eveskin
- wisky
TODO
- Remove the code https://gerrit.wikimedia.org/r/c/mediawiki/core/+/930261
- Email wikitech-l describing how to fix broken skins