Thumbnail component icon shouldn't change color on select
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• STH
	Apr 27 2022, 3:24 PM

Description

Currently, the color of placeholder thumbnail icons changes to blue (Accent50) when a MenuItem is active / being selected. (You can experience this behavior using any of the TypeaheadSearch component demos).

This shouldn't happen because, unlike ItemMenu icons, placeholder thumbnails are not part of the interactive option being selected: they are only a decorative way of indicating that the related image is missing.

Acceptance criteria

Placeholder thumbnail icons don't change color when MenuItems are selected

Details

Other Assignee: • EUdoh-WMF

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	MenuItem: Update thumbnail styles	design/codex	main	+141 -177

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Duplicate	None	T299666 Add TypeaheadSearch component to Codex
Resolved	• Sarai-WMDE	T297025 Add TypeaheadSearch to Codex
Resolved	• Sarai-WMDE	T300652 Design Thumbnail component
Resolved	• DAbad	T307001 Thumbnail component icon shouldn't change color on select

Event Timeline

• STH created this task.Apr 27 2022, 3:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 27 2022, 3:24 PM

• STH triaged this task as Medium priority.Apr 27 2022, 3:24 PM

• STH added a project: Codex.

• STH added a parent task: T297025: Add TypeaheadSearch to Codex.

• STH moved this task from Up Next to Backlog on the Design-System-Team board.Apr 30 2022, 6:03 PM

• Sarai-WMDE updated the task description. (Show Details)May 5 2022, 2:35 PM

• Sarai-WMDE updated the task description. (Show Details)May 5 2022, 2:42 PM

• Sarai-WMDE renamed this task from Thumbnail component icon changes color on select to Thumbnail component icon shouldn't change color on select.May 5 2022, 2:46 PM

Change 789269 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[design/codex@main] MenuItem: Update thumbnail styles

https://gerrit.wikimedia.org/r/789269

gerritbot added a project: Patch-For-Review.May 5 2022, 3:45 PM

Catrope edited projects, added Design-System-Team (Design-System-Sprint); removed Design-System-Team.May 5 2022, 6:51 PM

Catrope moved this task from Committed to Design Sign-Off on the Design-System-Team (Design-System-Sprint) board.

Change 789269 merged by jenkins-bot:

[design/codex@main] MenuItem: Update thumbnail styles

https://gerrit.wikimedia.org/r/789269

Maintenance_bot removed a project: Patch-For-Review.May 5 2022, 7:30 PM

• Sarai-WMDE updated the task description. (Show Details)May 6 2022, 8:19 AM

This issue has been solved thanks to the linked patch!