Page MenuHomePhabricator

Thumbnail component icon shouldn't change color on select
Closed, ResolvedPublic

Description

Currently, the color of placeholder thumbnail icons changes to blue (Accent50) when a MenuItem is active / being selected. (You can experience this behavior using any of the TypeaheadSearch component demos).

This shouldn't happen because, unlike ItemMenu icons, placeholder thumbnails are not part of the interactive option being selected: they are only a decorative way of indicating that the related image is missing.

Acceptance criteria

  • Placeholder thumbnail icons don't change color when MenuItems are selected

Details

Event Timeline

STH triaged this task as Medium priority.Apr 27 2022, 3:24 PM
STH added a project: Codex.
Sarai-WMDE renamed this task from Thumbnail component icon changes color on select to Thumbnail component icon shouldn't change color on select.May 5 2022, 2:46 PM

Change 789269 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[design/codex@main] MenuItem: Update thumbnail styles

https://gerrit.wikimedia.org/r/789269

Change 789269 merged by jenkins-bot:

[design/codex@main] MenuItem: Update thumbnail styles

https://gerrit.wikimedia.org/r/789269

This issue has been solved thanks to the linked patch!

Screenshot 2022-05-06 at 10.29.01.png (668×1 px, 268 KB)

Sarai-WMDE added a subscriber: Sarai-WMDE.
DAbad claimed this task.
DAbad added a subscriber: DAbad.

closed