Diff is not show when Realtime Preview is on
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Nux
	Apr 27 2022, 10:44 PM

Description

List of steps to reproduce (step by step, including full links if applicable):

Log in (works a bit differently for anons).
Edit any page or section e.g. https://pl.wikipedia.org/w/index.php?title=Elisa_Ferreira&action=edit&section=0
Enable Realtime Preview.
Do some change (e.g. remove all wikicode).
Preview changes (wpDiff button).

What happens?:

No changes are shown. Realtime Preview is enabled.

For anonymous this a bit different. Changes are shown until you press Preview (of Realtime Preview).

What should have happened instead?:

Both should be visible -- diff and Realtime Preview.

Normal, static preview should be hidden (wpPreview button preview). But changes preview (diff) should be visible.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

This is after pressing "Podgląd zmian" (wpDiff).

Details

	Subject	Repo	Branch	Lines +/-
	Fix unrelated elements flickering during realtime preview	mediawiki/extensions/WikiEditor	master	+6 -1
	Realtime Preview: don't hide diff view on refresh	mediawiki/extensions/WikiEditor	master	+3 -1

Customize query in gerrit

Related Objects

Mentioned Here: rEIPI6364c8a74d10: Localisation updates from https://translatewiki.net.

Event Timeline

Nux created this task.Apr 27 2022, 10:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 27 2022, 10:44 PM

Piastu subscribed.Apr 28 2022, 8:38 AM

• NRodriguez added a project: Community-Tech (CommTech-Sprint-28).Jun 30 2022, 5:30 PM

• JMcLeod_WMF set the point value for this task to 3.Jul 6 2022, 11:10 AM

MusikAnimal claimed this task.Jul 6 2022, 8:19 PM

MusikAnimal moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-28) board.

Change 811775 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/WikiEditor@master] Realtime Preview: don't hide diff view on refresh

https://gerrit.wikimedia.org/r/811775

gerritbot added a project: Patch-For-Review.Jul 6 2022, 8:35 PM

MusikAnimal moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-28) board.Jul 6 2022, 8:52 PM

HMonroy moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-28) board.Jul 7 2022, 9:52 PM

Change 811775 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Realtime Preview: don't hide diff view on refresh

https://gerrit.wikimedia.org/r/811775

Maintenance_bot removed a project: Patch-For-Review.Jul 7 2022, 10:31 PM

I can now view diffs ("Show changes") alongside Realtime Preview.

I tested RTP in both automatic and manual reload modes.

I tested diffs with normal and Live preview enabled.

Test environment: https://en.wikipedia.beta.wmflabs.org IP Info 0.0.0 (6364c8a) 06:52, 8 July 2022.
Skins: Vector 2022, Vector 2010, Minerva.
Browsers: Firefox 91, Chromium 87.

Great job jumping on this P0 bug!

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 12 2022, 5:01 AM

Change 957252 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/WikiEditor@master] Fix unrelated elements flickering during realtime preview

https://gerrit.wikimedia.org/r/957252

gerritbot added a project: Patch-For-Review.Sep 13 2023, 9:20 AM

Change 957252 merged by jenkins-bot: