Page MenuHomePhabricator

[IP Masking] Temporary account Timeless support
Closed, ResolvedPublic

Description

Update the Timeless skin for the existence of "temporary users", a new category of users introduced in the 2022/temp-user topic branch in Gerrit.

I think the only thing to do here is to clean up the personal menu. Currently I see the temporary username prefixed with the message timeless-loggedinas "Logged in as $1", and also a duplicate menu item with ID pt-tmpuserpage. Calling temporary users "logged in" is inconsistent with the general product design in which temporary users are invited to log in or create an account, as if they are not already logged in. So we probably want to say something else there.

Event Timeline

Change 913645 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/Timeless@master] Add support for temporary user accounts

https://gerrit.wikimedia.org/r/913645

matmarex subscribed.

I had a problem with the "Temporary account" anchored popup message when working on this patch.

At first it would appear in the top-left corner, at coordinates (0,0), because the ".mw-userpage-tmp" element that it's supposed to anchor to was hidden in the dropdown user menu:

image.png (2×3 px, 236 KB)

I tried to move the ".mw-userpage-tmp" class to the menu header, but that hardly helped, because now the popup is covered by the post-edit message (and partially covered by the sticky header as well):

image.png (2×3 px, 228 KB)

In the end, I just made it disappear:

image.png (2×3 px, 193 KB)

However, the message seems important to include.

I wonder if we could simply display it in a mw.notify() notification, like the post-edit message, if the skin doesn't have a good place to display the anchored popup?

Change 913648 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Improve temp user account creation post-edit message skin compat

https://gerrit.wikimedia.org/r/913648

Change 913648 merged by jenkins-bot:

[mediawiki/core@master] Improve temp user account creation post-edit message skin compat

https://gerrit.wikimedia.org/r/913648

Looks pleasing:

image.png (2×3 px, 213 KB)

This looks nice!

One quick question, does the second popup disappears on its own or does it need to be dismissed?

It doesn't disappear on its own, and needs to be dismissed by clicking it. (Or the user can just ignore it until they leave the page.) The separate "Your edit was published" notification disappears on its own.

Change 913645 merged by jenkins-bot:

[mediawiki/skins/Timeless@master] Add support for temporary user accounts

https://gerrit.wikimedia.org/r/913645