Page MenuHomePhabricator
Create Task
Maniphest T307071

Centralize "start icon padding" style logic
Closed, ResolvedPublic
Actions

Description

The start Icon container logic has now been replicated in 3 different components (TypeaheadSearch, TexInput, Select) and it should be centralized to avoid duplication.

Definition of done

  • Create new mixins
  • Update Select.vue
  • Update textInput.vue
  • Update typeaheadSearch

Details

SubjectRepoBranchLines +/-
Style: Refactor icon positioning in TypeaheadSearch using mixindesign/codexmain+16 -25
styles: Centralize "start icon padding" style logicdesign/codexmain+78 -88
Customize query in gerrit

Event Timeline

SimoneThisDot created this task.Apr 28 2022, 7:45 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 28 2022, 7:45 AM
SimoneThisDot added a project: Codex.Apr 28 2022, 10:12 AM
• STH moved this task from Inbox to Up Next on the Design-System-Team board.Apr 30 2022, 5:54 PM
• STH triaged this task as Medium priority.Apr 30 2022, 6:04 PM
• STH added a project: good first task.Apr 30 2022, 6:10 PM
SimoneThisDot changed the task status from Open to In Progress.May 4 2022, 12:15 PM
SimoneThisDot claimed this task.
SimoneThisDot moved this task from Up Next to Design-System-Sprint on the Design-System-Team board.
SimoneThisDot edited projects, added Design-System-Team (Design-System-Sprint); removed Design-System-Team.
SimoneThisDot moved this task from Committed to In Development on the Design-System-Team (Design-System-Sprint) board.
SimoneThisDot updated the task description. (Show Details)
gerritbot added a comment.May 4 2022, 12:18 PM

Change 789134 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[design/codex@main] Centralize "start icon padding" style logic

https://gerrit.wikimedia.org/r/789134

gerritbot added a project: Patch-For-Review.May 4 2022, 12:18 PM
SimoneThisDot added a comment.May 4 2022, 1:40 PM

FYI: I have not updated the typedahead yet as it is still in current changes and development.

Catrope removed SimoneThisDot as the assignee of this task.May 10 2022, 7:18 PM
Catrope moved this task from In Development to Ready for Development on the Design-System-Team (Design-System-Sprint) board.
Catrope subscribed.

Moving back to Ready for Dev because TypeaheadSearch isn't done yet. @SimoneThisDot I'm unassigning from you because your patch is merged, but feel free to assign this to yourself again if/when you work on the TypeaheadSearch piece.

gerritbot added a comment.May 10 2022, 7:26 PM

Change 789134 merged by jenkins-bot:

[design/codex@main] styles: Centralize "start icon padding" style logic

https://gerrit.wikimedia.org/r/789134

Maintenance_bot removed a project: Patch-For-Review.May 10 2022, 7:30 PM
SimoneThisDot claimed this task.May 13 2022, 10:02 AM
SimoneThisDot moved this task from Ready for Development to Code Review on the Design-System-Team (Design-System-Sprint) board.
SimoneThisDot updated the task description. (Show Details)
  • Update typeaheadSearch
gerritbot added a comment.May 13 2022, 11:01 AM

Change 791587 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[design/codex@main] Style: Refactor icon positioning in TypeaheadSearch using mixin

https://gerrit.wikimedia.org/r/791587

gerritbot added a project: Patch-For-Review.May 13 2022, 11:01 AM
AnneT added subscribers: Sarai-WMDE, AnneT.May 13 2022, 6:14 PM

@Sarai-WMDE Simone has refactored some of the code around start-icon padding in TypeaheadSearch. When you get a chance, could you please look over the demo and confirm if everything is good to go here?

Sarai-WMDE added a comment.May 16 2022, 12:10 PM

Thanks for the heads-up and the useful link, Anne! I'm not noticing any visual alterations in the components affected by the change. Just left a small comment in the patch, though. Let's wait until everything is resolved to move the ticket forward on the board.

gerritbot added a comment.May 16 2022, 4:31 PM

Change 791587 merged by jenkins-bot:

[design/codex@main] Style: Refactor icon positioning in TypeaheadSearch using mixin

https://gerrit.wikimedia.org/r/791587

Maintenance_bot removed a project: Patch-For-Review.May 16 2022, 5:30 PM
SimoneThisDot moved this task from Code Review to Design Sign-Off on the Design-System-Team (Design-System-Sprint) board.May 17 2022, 11:39 AM

All changes have been addressed and the Patch merged. Moving the ticket forward for design review.

Sarai-WMDE added a comment.May 18 2022, 1:35 PM

No visual issues were detected. LGTUX.

Sarai-WMDE moved this task from Design Sign-Off to QTE Sign-off on the Design-System-Team (Design-System-Sprint) board.May 18 2022, 1:35 PM
NBaca-WMF moved this task from Design-System-Sprint to Functional Testing Backlog on the Design-System-Team board.Jun 3 2022, 9:39 PM
NBaca-WMF edited projects, added Design-System-Team; removed Design-System-Team (Design-System-Sprint).
NBaca-WMF subscribed.

Moving Functional Testing of this component out of this current sprint and into the general Team Functional Testing column, in order to focus on current sprint goals, which primarily include preparing Typeahead Search and several other smaller tasks.

A related reason for doing this is to ensure we have time to triage any tickets or followup work that might come from the functional review of this fix.

Will pick up when prioritized for release.

ldelench_wmf moved this task from Functional Testing Backlog to Backlog on the Design-System-Team board.Sep 16 2022, 6:19 PM
egardner moved this task from Inbox to Proposed Component Updates on the Codex board.Feb 22 2023, 12:31 AM
AnneT closed this task as Resolved.Oct 12 2023, 9:09 PM
AnneT updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL