We are still ES5. Newer versions of videojs have dropped support for ES5. Our current code doesn't actually run on IE11 because it is using ES6 T306711: OgvJs crashes with syntax error on IE11.
This indicates that within the next year or so we have to switch the whole player to ES6. This also allows us to make use of classes and other features which would definetly cleanup the code.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T334853 Clean up JS code now that we can use ES6 rather than ES5 across all Wikimedia deployed codebases | |||
| Resolved | TheDJ | T307075 Convert videoJS player to ES6 |
Change 798995 had a related patch set uploaded (by TheDJ; author: TheDJ):
[mediawiki/extensions/TimedMediaHandler@master] Mark TMH modules as requiring ES6
Change 798995 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Mark TMH modules as requiring ES6
Probably not, as T178356: Raise Grade A JavaScript requirement from ES5 (2009) to ES6 (2015) is resolved?
But may also decline this task in favor of T334235: Update VideoJS player to 8+ version?
Change 923312 had a related patch set uploaded (by TheDJ; author: TheDJ):
[mediawiki/extensions/TimedMediaHandler@master] [WIP] Convert TMH modules to ES6
Change 923365 had a related patch set uploaded (by TheDJ; author: TheDJ):
[mediawiki/extensions/TimedMediaHandler@master] Rewrite ext.tmh.player.dialog to use es6 class
Change 923373 had a related patch set uploaded (by TheDJ; author: TheDJ):
[mediawiki/extensions/TimedMediaHandler@master] Convert ext.tmh.player.element to es6 class
Change 923312 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Convert TMH modules to ES6
Change 923365 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Rewrite ext.tmh.player.dialog to use es6 class
Change 923373 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Convert ext.tmh.player.element to es6 class
Change 923672 had a related patch set uploaded (by TheDJ; author: TheDJ):
[mediawiki/extensions/TimedMediaHandler@master] Set linting more strict and add no-jquery plugin
Change 923702 had a related patch set uploaded (by TheDJ; author: TheDJ):
[mediawiki/extensions/TimedMediaHandler@master] Convert more anonymous functions to arrow functions
Change 923705 had a related patch set uploaded (by TheDJ; author: TheDJ):
[mediawiki/extensions/TimedMediaHandler@master] Convert OgvJsSupport to es6 class
Change 923672 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Set linting more strict and add no-jquery plugin
Change 923702 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Convert more anonymous functions to arrow functions
Change 923705 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Convert OgvJsSupport to es6 class
After the video.js update patch lands, essentially all code will be es6. Only the videojs-ogvjs tech plugin still requires converting, which I might do at some later point in time (not super essential).
There is still some packageFiles cleanup that can be done, and we probably can get rid of 1 or 2 more RL modules.