Page MenuHomePhabricator

Improve preview button look and feel in the Editor toolbar
Closed, ResolvedPublic


⚠️Hover (default) – background: Base80
Screen Shot 2022-04-11 at 16.30.22.png (878×1 px, 50 KB)
⚠️Active – label should be blue as well
Screen Shot 2022-04-11 at 16.31.46.png (688×772 px, 138 KB)
⚠️Hover (while active) – background: Base80
Screen Shot 2022-04-11 at 16.23.24.png (884×1 px, 167 KB)

Event Timeline

TheresNoTime assigned this task to Samwilson.
TheresNoTime added a subscriber: TheresNoTime.

Resolved in 6a91c1f3ea54

@TheresNoTime thanks for reviewing and merging this! I actually forgot to update the commit message with this (new) task number (the one on it is for the parent task), so here it is for posterity:

Also, rather than closing directly, after review we move things to the QA column so that they can be checked by the Test engineers can find the bugs we wrote take a look at our work. There's some more info about the workflow at

Hi @TheresNoTime and @Samwilson, I wanted to make sure that we're also adding the same small border on the other edge of the button – currently it's not visible on Pl-Wiki but maybe you already added to this patch, in that case forget I said anything :) thanks!

Currently – Without borderWith Border
Screen Shot 2022-05-05 at 22.17.41-a.jpg (1×1 px, 298 KB)
Screen Shot 2022-05-05 at 22.17.41_b.jpg (1×1 px, 299 KB)

@nayoub good point, but yep we caught that one. Actually, it was a bug from T296447, in that the new section's groups never had their side border switched.

It's now looking like this:

Screenshot 2022-05-06 at 13-51-11 Editing Main Page - Dev wiki1.png (148×274 px, 3 KB)
NRodriguez added a subscriber: NRodriguez.

Can't wait to be using this in Meta wiki too!