Page MenuHomePhabricator

[Bug] Table of contents should not appear in edit mode
Closed, ResolvedPublic2 Estimated Story Points

Description

Steps to reproduce

  1. Go to https://en.wikipedia.org/wiki/Paige_Bueckers and select edit
  2. Switch to the Visual Editor

Expected:

  • ToC should not appear as per T294950

Observed:

  • ToC appears

Developer notes

A skin style should be added inside Vector that uses the ve-activated class. Use a skin style so this is not loaded unnecessarily in other contexts

QA Results - Beta

ACStatusDetails
1T307112#7901713

QA Results - Prod

ACStatusDetails
1T307112#7920857

Event Timeline

ovasileva renamed this task from Table of contents should not appear in edit mode to [Bug] Table of contents should not appear in edit mode.Apr 28 2022, 2:35 PM
ovasileva triaged this task as High priority.

Change 787555 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Disable TOC in edit mode

https://gerrit.wikimedia.org/r/787555

Change 787555 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Disable TOC in edit mode

https://gerrit.wikimedia.org/r/787555

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to https://en.wikipedia.org/wiki/Paige_Bueckers and select edit
Switch to the Visual Editor
✅ AC1: ToC should not appear as per T294950

Screen Shot 2022-05-03 at 6.40.11 PM.png (1×1 px, 441 KB)

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to https://en.wikipedia.org/wiki/Paige_Bueckers and select edit
Switch to the Visual Editor
✅ AC1: ToC should not appear as per T294950

Screen Shot 2022-05-11 at 6.28.25 AM.png (812×987 px, 204 KB)

Screen Shot 2022-05-11 at 6.27.59 AM.png (811×1 px, 317 KB)

Edtadros updated the task description. (Show Details)
Edtadros added a subscriber: Edtadros.