Add link to project page next to skin listing for desktop improvements
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	ovasileva
	Apr 28 2022, 2:39 PM

Description

Background

We want to make it easier for people to find the talk page of the desktop improvements project so that they can give us feedback

Acceptance criteria

Add link on preferences page that leads to the project talk page for desktop imrovements (https://www.mediawiki.org/wiki/Talk:Reading/Web/Desktop_Improvements)
Link should appear before Preview link
Link copy: "Discussion"

QA

Login and visit https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences?tableofcontents=0#mw-prefsection-rendering
Assert that a "Discussion" link appears before the "Preview" link next the Vector 2022 skin option.
The link should go to https://www.mediawiki.org/wiki/Talk:Reading/Web/Desktop_Improvements

QA Results - Beta

AC	Status	Details
1	✅	T307113#7948668
2	✅	T307113#7948668

QA Results - Prod

AC	Status	Details
1	✅	T307113#7948670
2	✅	T307113#7948670

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add optional link to project talk page next to a skin's listing	mediawiki/core	master	+6 -0
	Add message for the desktop improvements project's talk page	mediawiki/skins/Vector	master	+2 -0

Customize query in gerrit

Related Objects

Mentioned In: T308653: Add link to project page next to Minerva skin listing
Mentioned Here: T306246: PageImages ignores MediaWiki:Bad image list, (uses MediaWiki:Pageimages-denylist instead) displaying search results that are inappropriate for some readers

Event Timeline

ovasileva created this task.Apr 28 2022, 2:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 28 2022, 2:39 PM

ovasileva triaged this task as Medium priority.Apr 28 2022, 2:39 PM

sgrabarczuk subscribed.Apr 28 2022, 3:20 PM

Are you talking about here?:

Screen Shot 2022-04-28 at 8.38.15 AM.png (384×1 px, 104 KB)

IF so we'd need to provide a generic capability for all skins to register a talk page.

I think we could do this in DefaultPreferencesFactory::generateSkinOptions where we have access to the skin key based on the existence of a message e.g. "<skinname>-prefs-talkpage"

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Apr 28 2022, 3:42 PM

Yeah, right now, there's no easy way to find our project page or project talk page, which is becoming an issue, since more individuals and communities do/are going to have Vector 2022 as default.

If Vector 2022 was a beta feature, there would be Information and Discussion links provided, because that's the standard for beta features. So we need to find a workaround.

I agree that adding a link to the project page is a good idea.

In T307113#7888446, @sgrabarczuk wrote:

Yeah, right now, there's no easy way to find our project page or project talk page, which is becoming an issue, since more individuals and communities do/are going to have Vector 2022 as default.

If Vector 2022 was a beta feature, there would be Information and Discussion links provided, because that's the standard for beta features. So we need to find a workaround.

T306246 should be a blocker for rolling out Vector 2022 as default. (unless wgVectorWvuiSearchOptions is disabled)

Jdlrobson unsubscribed.Apr 28 2022, 8:40 PM

Jdlrobson moved this task from Backlog to It's not a priority on the MediaWiki-Core-Skin-Architecture board.May 2 2022, 5:04 PM

LGoto set the point value for this task to 3.May 4 2022, 4:43 PM

LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.

ovasileva updated the task description. (Show Details)May 4 2022, 4:43 PM

ovasileva removed the point value 3 for this task.

ovasileva updated the task description. (Show Details)

ovasileva set the point value for this task to 3.

ovasileva raised the priority of this task from Medium to High.May 9 2022, 5:25 PM

Jdlrobson added a project: patch-welcome.May 9 2022, 10:44 PM

• nray claimed this task.May 10 2022, 5:14 PM

• nray moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.

Change 791472 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/core@master] Add optional a link to project talk page next to a skin's listing that

https://gerrit.wikimedia.org/r/791472

gerritbot added a project: Patch-For-Review.May 13 2022, 12:17 AM

• nray removed • nray as the assignee of this task.May 13 2022, 12:22 AM

• nray moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.

• nray subscribed.

Jdlrobson claimed this task.May 13 2022, 3:12 PM

Change 791635 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@master] Add message for the desktop improvements project's talk page

https://gerrit.wikimedia.org/r/791635

• nray reassigned this task from Jdlrobson to Edtadros.May 13 2022, 4:13 PM

• nray moved this task from Code Review to QA on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.

• nray updated the task description. (Show Details)

• nray added a subscriber: Jdlrobson.

• nray updated the task description. (Show Details)May 13 2022, 4:16 PM

Change 791472 merged by jenkins-bot:

[mediawiki/core@master] Add optional link to project talk page next to a skin's listing

https://gerrit.wikimedia.org/r/791472

Change 791635 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Add message for the desktop improvements project's talk page

https://gerrit.wikimedia.org/r/791635

Maintenance_bot removed a project: Patch-For-Review.May 13 2022, 4:30 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 14 2022, 4:00 AM

Samwalton9-WMF mentioned this in T308653: Add link to project page next to Minerva skin listing.May 18 2022, 10:11 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Login and visit https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences?tableofcontents=0#mw-prefsection-rendering
✅ AC1: Assert that a "Discussion" link appears before the "Preview" link next the Vector 2022 skin option.

Screen Shot 2022-05-22 at 6.34.48 PM.png (334×664 px, 57 KB)

✅ AC2: The link should go to https://www.mediawiki.org/wiki/Talk:Reading/Web/Desktop_Improvements

Screen Shot 2022-05-22 at 6.35.10 PM.png (428×715 px, 89 KB)

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Login and visit https://en.wikipedia.org/wiki/Special:Preferences?tableofcontents=0#mw-prefsection-rendering
✅ AC1: Assert that a "Discussion" link appears before the "Preview" link next the Vector 2022 skin option.

Screen Shot 2022-05-22 at 6.38.47 PM.png (557×895 px, 101 KB)

✅ AC2: The link should go to https://www.mediawiki.org/wiki/Talk:Reading/Web/Desktop_Improvements

Screen Shot 2022-05-22 at 6.38.57 PM.png (843×861 px, 152 KB)

Edtadros updated the task description. (Show Details)May 23 2022, 1:40 AM

LGoto removed Edtadros as the assignee of this task.May 23 2022, 5:20 PM

LGoto added a subscriber: Edtadros.

Jdlrobson assigned this task to Jdrewniak.May 24 2022, 5:07 PM

Jdrewniak closed this task as Resolved.May 31 2022, 4:19 AM

	F35167606: Screen Shot 2022-05-22 at 6.38.57 PM.png
	May 23 2022, 1:39 AM

	F35167604: Screen Shot 2022-05-22 at 6.38.47 PM.png
	May 23 2022, 1:39 AM

	F35167596: Screen Shot 2022-05-22 at 6.35.10 PM.png
	May 23 2022, 1:36 AM

	F35167594: Screen Shot 2022-05-22 at 6.34.48 PM.png
	May 23 2022, 1:36 AM

	F35072156: Screen Shot 2022-04-28 at 8.38.15 AM.png
	Apr 28 2022, 3:42 PM

Add link to project page next to skin listing for desktop improvementsClosed, ResolvedPublic3 Estimated Story PointsActions

Description

Background

Acceptance criteria

QA

QA Results - Beta

QA Results - Prod

Details

Related Objects

Event Timeline

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

Add link to project page next to skin listing for desktop improvements
Closed, ResolvedPublic3 Estimated Story Points
Actions