Maniphest T307239

🟧 Respond with 400 status code in case of an invalid statement id
Closed, ResolvedPublic
Actions

Assigned To

Ollie.Shotton_WMDE

Authored By

	Silvan_WMDE
	Apr 29 2022, 3:38 PM

Tags

Referenced Files

None

Subscribers

Ollie.Shotton_WMDE

Description

invalid statement IDs include those of statements that are not on Items

error code: invalid-statement-id
error message: "Not a valid statement ID: {statement_id}"

Details

	Subject	Repo	Branch	Lines +/-
	REST: Add validation to GetItemStatement use case	mediawiki/extensions/Wikibase	master	+342 -7

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T335067 Epic: Wikidata Query Service stabilization
		Resolved		Lydia_Pintscher	T314503 rollout of the new Wikibase REST API to Wikidata
		Invalid		None	T301860 Enable reading and modifying a statement of item or property using REST API
		Open		None	T344228 Functionality for REST API v1
		Resolved		WMDE-leszek	T306917 Request data of a single statement of an item
		Resolved		WMDE-leszek	T307087 🟧 Create an initial implementation of GET /statements/{statement_id}
		Resolved		Ollie.Shotton_WMDE	T307239 🟧 Respond with 400 status code in case of an invalid statement id

Event Timeline

Silvan_WMDE created this task.Apr 29 2022, 3:38 PM

Jakob_WMDE updated the task description. (Show Details)May 2 2022, 12:42 PM

Jakob_WMDE mentioned this in T307087: 🟧 Create an initial implementation of GET /statements/{statement_id}.May 3 2022, 12:54 PM

Ollie.Shotton_WMDE claimed this task.May 9 2022, 2:15 PM

Ollie.Shotton_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 5) board.

WMDE-leszek edited projects, added Wikibase Product Platform (v1) (Sprint 6); removed Wikibase Product Platform (v1) (Sprint 5).May 11 2022, 12:04 PM

WMDE-leszek moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 6) board.

Change 791048 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Add validation to GetItemStatement use case

https://gerrit.wikimedia.org/r/791048

gerritbot added a project: Patch-For-Review.May 11 2022, 3:39 PM

Ollie.Shotton_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 6) board.May 12 2022, 8:06 AM

Change 791048 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add validation to GetItemStatement use case

https://gerrit.wikimedia.org/r/791048

Maintenance_bot removed a project: Patch-For-Review.May 13 2022, 2:30 PM

Ollie.Shotton_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 6) board.May 13 2022, 3:42 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 13 2022, 4:00 PM

WMDE-leszek closed this task as Resolved.May 25 2022, 12:43 PM