Hey @cscott is this task still blocked on you or do you need input from someone else e.g. my team or Daniel? Who is responsible for merging https://gerrit.wikimedia.org/r/c/mediawiki/core/+/802678 ?

I think this part of the task can be unblocked, as we've got some consensus around the ParserOutput portion of the task I think. We need a patch which sets the ParserOptions flag to finish the work on T307691, and I've got an initial version here: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/805897

There is handful of user scripts that update the page content without full reload, sometimes adding new sections: Convenient-Discussions, QuickEdit. I'm sure you will take care of Visual Editor and DiscussionTools, but what will be the mechanism that other tools could use to initiate the TOC re-rendering? If it's not automatic on mw.hook('wikipage.content').fire(), of course. (But this is often used outside #mw-content-text, to make scripts run on some content. And theoretically some tools could update not the whole #mw-content-text but a part of it.)

The mechanism I proposed would be usable by any user script etc. as well. You'd add &prop=sections to your action=parse API request, then pass a part of the result to mw.hook( 'wikipage.tableOfContents' ).fire( … ). You can see the implementation for the core MediaWiki live preview in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/802679/8/resources/src/mediawiki.page.preview.js.

That sounds great.

Change 811829 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/Vector@master] [ToC] Show new/modified sections after publishing an edit (new floating ToC) POC #1

https://gerrit.wikimedia.org/r/811829

Change 811830 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/core@master] [ToC] Show new/modified sections after publishing an edit (new floating ToC) POC #1

https://gerrit.wikimedia.org/r/811830

Change 811831 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/extensions/VisualEditor@master] [ToC] Show new/modified sections after publishing an edit (new floating ToC) POC #1

https://gerrit.wikimedia.org/r/811831

Change 812915 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/Vector@master] [ToC] Show new/modified sections after publishing an edit (new floating ToC) POC #1

https://gerrit.wikimedia.org/r/812915

Change 812915 abandoned by Mabualruz:

[mediawiki/skins/Vector@master] [ToC] Show new/modified sections after publishing an edit (new floating ToC) POC #1

Reason:

https://gerrit.wikimedia.org/r/812915

Almost done with client side template rendering solution, it will be in review by tomorrow

Change 811831 abandoned by Mabualruz:

[mediawiki/extensions/VisualEditor@master] [ToC] Show new/modified sections after publishing an edit (new floating ToC) POC #1

Reason:

https://gerrit.wikimedia.org/r/811831

Change 811830 abandoned by Mabualruz:

[mediawiki/core@master] [ToC] Show new/modified sections after publishing an edit (new floating ToC) POC #1

Reason:

https://gerrit.wikimedia.org/r/811830

Change 811829 abandoned by Mabualruz:

[mediawiki/skins/Vector@master] [ToC] Show new/modified sections after publishing an edit (new floating ToC) POC #1

Reason:

https://gerrit.wikimedia.org/r/811829

Change 821748 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/Vector@master] [ToC] Show new/modified sections after publishing an edit (new floating ToC)

https://gerrit.wikimedia.org/r/821748

Change 821748 merged by jenkins-bot:

[mediawiki/skins/Vector@master] [ToC] Show new/modified sections after publishing an edit (new floating ToC)

https://gerrit.wikimedia.org/r/821748

Looking good for me on test.wiki. Moving to QA in Prod

Example Article with TOC - https://test.wikipedia.org/wiki/Wikipedia:Village_pump

Change 802676 abandoned by Bartosz Dziewoński:

[mediawiki/skins/Vector@master] Handle new 'wikipage.tableOfContents' hook to update TOC dynamically

Reason:

Superseded by https://gerrit.wikimedia.org/r/821748

https://gerrit.wikimedia.org/r/802676

There are issues with the current version when editing using visual editor:

• If headings are added to an article that previously had less than 4, the TOC should be shown, but it isn't (until you reload the page)
• If headings are removed from an article that previously had at least 4, the TOC should be hidden, but it isn't (until you reload the page)

In T307251#8167742, @matmarex wrote:

There are issues with the current version when editing using visual editor:

• If headings are added to an article that previously had less than 4, the TOC should be shown, but it isn't (until you reload the page)
• If headings are removed from an article that previously had at least 4, the TOC should be hidden, but it isn't (until you reload the page)

Has there been a discussion among designers / general public as to whether there is a need to hide the sidebar TOC when there is less than 4 sections? It would seem to me that since the TOC is not part of the content anymore, there is no reason to fine-tune its presence in such a way.

Not that I know of, but I don't think this matters here. The bug also occurs when the table of contents is forced on or off using __TOC__ / __NOTOC__ magic words, or in visual editor's page options:

I've opened T315862 and T315863 for the two remaining issues. Let's continue conversation on relevant tickets.

@ovasileva - to test again on pilot wikis

Bug with subsection toggle buttons: T316033.

And current section highlighting doesn't work as well: T316037.