Page MenuHomePhabricator

IP Info: Enable on watchlist
Closed, ResolvedPublic1 Estimated Story Points

Description

Motivation

There has been a piece of feedback asking about IP Info being enabled on their watchlist page. It would be beneficial to patrollers who add articles they are interested in to their watchlist and use this as their patrolling tool.

Spec:
  • Enable IP Info on Special:Watchlist (similar to how it works on Special:RecentChanges)

Event Timeline

Niharika triaged this task as Medium priority.Apr 30 2022, 12:26 AM
Niharika created this task.
Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptApr 30 2022, 12:26 AM

Change 787882 had a related patch set uploaded (by Steven Sun; author: Steven Sun):

[mediawiki/extensions/IPInfo@master] Enable IPInfo on Special:Watchlist

https://gerrit.wikimedia.org/r/787882

AGueyte set the point value for this task to 1.May 2 2022, 5:10 PM

Change 787882 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Enable IPInfo on Special:Watchlist

https://gerrit.wikimedia.org/r/787882

@Niharika @Tchanders There might be some changes to make this work for Eventlogging. For example, opening a popup in Special:Watchlist we send the event:

{
  "$schema": "/analytics/mediawiki/ipinfo_interaction/1.2.0",
  "event_action": "open_popup",
  "event_context": "page",
  "event_source": "Watchlist",
  "user_edit_bucket": "1000+ edits",
  "user_groups": "ipblock-exempt|sysop|*|user|named|autoconfirmed",
  "event_ipinfo_version": "full",
  "meta": {
    "stream": "mediawiki.ipinfo_interaction",
    "domain": "en.wikipedia.beta.wmflabs.org"
  },
  "dt": "2022-05-04T11:02:10.302Z"
}

With event_source: "Watchlist. I don't know if that is correct. There may be other changes we need to make as well.

I now see IPInfo popups on Special:Watchlist.

I tested it for several different settings of the Special:Watchlist page (which you can see when you go to the Watchlist tab in Special:Preferences. e.g. normal vs. enhanced vs. "non-Javascript" interface).

I tested that it worked for Live updates in normal and enhanced mode.

For those I checked, the revision ID IPInfo was looking up corresponded to the revision ID of the entry in Special:Watchlist.

I briefly tested it in RTL in normal and enhanced mode.

As I understand it, Special:Watchlist shares a lot of the same functionality as Special:RecentChanges. If it works on the latter it should work on the former.

I found a small UI bug, but doubt it is important T307659.

Test environment: local docker IP Info 0.0.0 (a3b1302) 09:00, 4 May 2022
Test browsers: Firefox 91, Chromium 87