Links in the TOC of vector 2022 are not clickable for some Chromium based browsers
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Func
	Apr 30 2022, 2:25 PM

Description

List of steps to reproduce (step by step, including full links if applicable):

Visit any page with TOC in vector 2022 via Chrome, https://en.wikipedia.org/wiki/Wikipedia:Contents?useskin=vector-2022
Try to click links of sections in the sidebar.

What happens?:
Nothing.

From 3c433a5315c7f4c864afa8ab5ee3497ce6f7a1c9: pointer-events: none;

What should have happened instead?:
Navigate to the respective section.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
Chrome 101.0.4951.41

QA Steps

Confirm fix on Edge 101.0.1210.32
Confirm fix on 101.0.4951.41

QA Results - Beta

AC	Status	Details
1	❌	T307271#7901708

Details

Project	Branch	Lines +/-	Subject
mediawiki/skins/Vector	wmf/1.39.0-wmf.10	+6 -11	[TOC] Remove pointer-events:none on .sidebar-toc-link
mediawiki/skins/Vector	master	+6 -11	[TOC] Remove pointer-events:none on .sidebar-toc-link
mediawiki/skins/Vector	wmf/1.39.0-wmf.9	+10 -7	[TOC] Remove pointer-events:none on .sidebar-toc-link

Customize query in gerrit

Related Objects

Mentioned In: T303785: Account creation: social media landing pages
T307288: [TOC] The table of contexts can not be clicked or jumped in Vector-2022
Mentioned Here: T303785: Account creation: social media landing pages
rSVEC3c433a5315c7: Add sectionObserver and tableOfContents component JS to respond to intersection…

Event Timeline

Func created this task.Apr 30 2022, 2:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 30 2022, 2:25 PM

Func added a subscriber: Jdrewniak.Apr 30 2022, 2:27 PM

50829 moved this task from Needs triage to Vector 2022 (tracking) on the Vector (legacy skin) board.May 1 2022, 5:39 AM

50829 mentioned this in T307288: [TOC] The table of contexts can not be clicked or jumped in Vector-2022.May 1 2022, 5:42 AM

50829 added a subscriber: 50829.

JJMC89 merged a task: T307288: [TOC] The table of contexts can not be clicked or jumped in Vector-2022.May 1 2022, 5:47 AM

50829 added a project: Desktop Improvements (Vector 2022).May 1 2022, 5:49 AM

50829 moved this task from Incoming to Table of Contents on the Desktop Improvements (Vector 2022) board.

Func moved this task from Vector 2022 (tracking) to Bugs on the Vector (legacy skin) board.May 1 2022, 6:24 AM

Stang added a subscriber: Stang.May 1 2022, 11:46 AM

StevenSun added a subscriber: StevenSun.May 1 2022, 12:04 PM

Jdlrobson removed a project: Regression.May 2 2022, 3:51 AM

Hooman_Mallahzadeh added a subscriber: Hooman_Mallahzadeh.May 2 2022, 4:13 AM

NguoiDungKhongDinhDanh added a subscriber: NguoiDungKhongDinhDanh.May 2 2022, 5:02 AM

Aklapper triaged this task as High priority.May 2 2022, 12:43 PM

Aklapper merged a task: T307347: Bug: ToC links not clickable.

Aklapper added a project: Web-Team-Backlog (Kanbanana-FY-2021-22).

Aklapper added a subscriber: ovasileva.

Seems to be an issue with pointer events AND display inline changing implementation in the most recent issue of Chrome:
Minimum test case:

`
<head>
    <style>
    .sidebar-toc .sidebar-toc-link > * {
         pointer-events: none;
    }
    </style>
</head>
<body><nav class="sidebar-toc">
	
	<ul >
		<li>
			<a href="#top-page" class="sidebar-toc-link">
				<div class="sidebar-toc-text">Beginning</div>
			</a>
		</li>
		
	</ul>
</nav>
</body>

Jdlrobson renamed this task from Links in the TOC of vector 2022 are not clickable for Chrome to Links in the TOC of vector 2022 are not clickable for some Chromium based browsers.May 2 2022, 2:09 PM

This bug has probably invalidated existing A/B test data as no clicks are being tracked @ovasileva

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.May 2 2022, 2:11 PM

I reported this bug at Village Pump using Edge, and reported that Chrome did respond to clicks. If someone else has repro'ed it in Chrome, then that's OK with me, but I'd like to be sure the fix applies to Edge too.

Jdlrobson updated the task description. (Show Details)May 2 2022, 2:25 PM

Lomrjyo added a subscriber: Lomrjyo.May 2 2022, 3:34 PM

ovasileva assigned this task to Jdrewniak.May 2 2022, 5:07 PM

ovasileva raised the priority of this task from High to Unbreak Now!.

Jdlrobson added a parent task: T305216: 1.39.0-wmf.10 deployment blockers.May 2 2022, 5:18 PM

NightWolf1223 added a subscriber: NightWolf1223.May 2 2022, 5:38 PM

Moving the pointer-events style to .sidebar-toc-text span seems to do the trick

LGoto set the point value for this task to 2.May 2 2022, 5:53 PM

LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Change 788388 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] [TOC] Remove pointer-events:none on .sidebar-toc-link

https://gerrit.wikimedia.org/r/788388

gerritbot added a project: Patch-For-Review.May 2 2022, 6:41 PM

Jdlrobson removed Jdrewniak as the assignee of this task.May 2 2022, 7:18 PM

Jdlrobson moved this task from Ready for Development to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Change 788338 had a related patch set uploaded (by Jdlrobson; author: Jdrewniak):

[mediawiki/skins/Vector@wmf/1.39.0-wmf.9] [TOC] Remove pointer-events:none on .sidebar-toc-link

https://gerrit.wikimedia.org/r/788338

Change 788338 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.39.0-wmf.9] [TOC] Remove pointer-events:none on .sidebar-toc-link

https://gerrit.wikimedia.org/r/788338

Jdlrobson lowered the priority of this task from Unbreak Now! to High.May 2 2022, 8:36 PM

Jdlrobson removed a parent task: T305216: 1.39.0-wmf.10 deployment blockers.

Mentioned in SAL (#wikimedia-operations) [2022-05-02T20:38:01Z] <catrope@deploy1002> Started scap: Backport: [[gerrit:788338|[TOC] Remove pointer-events:none on .sidebar-toc-link (T307271)]] and [[gerrit:788336|Video landing page: Show different title/body text on mobile (T303785)]]

Backported to all wikis and fixed in latest train. I've confirmed fix in production on Chrome 101 but we should check latest branch once more.

Mentioned in SAL (#wikimedia-operations) [2022-05-02T20:49:46Z] <catrope@deploy1002> Finished scap: Backport: [[gerrit:788338|[TOC] Remove pointer-events:none on .sidebar-toc-link (T307271)]] and [[gerrit:788336|Video landing page: Show different title/body text on mobile (T303785)]] (duration: 11m 45s)

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.9; 2022-04-25).May 2 2022, 9:00 PM

Jdlrobson assigned this task to Edtadros.May 3 2022, 5:15 PM

Test Result - Beta

Status: ❌ Fail
Environment: betai
OS: macOS Monterey
Browser: Edge 101.0.1210.32, Chrome 101.0.4951.41
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

❌ AC1: Confirm fix on Edge 101.0.1210.32

Screen Recording 2022-05-03 at 6.33.56 PM.mov.gif (1×972 px, 1 MB)

✅ AC2: Confirm fix on Chrome 101.0.4951.41

Screen Recording 2022-05-03 at 6.33.30 PM.mov.gif (988×972 px, 859 KB)

Edtadros updated the task description. (Show Details)May 4 2022, 1:38 AM

Jdlrobson removed Jdlrobson as the assignee of this task.May 4 2022, 3:08 AM

I can confirm this is fixed on Windows Edge 101.0.1210.32

@Edtadros - could you check Edge in production instead as a second verification?

Change 788388 merged by jenkins-bot:

[mediawiki/skins/Vector@master] [TOC] Remove pointer-events:none on .sidebar-toc-link

https://gerrit.wikimedia.org/r/788388

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.12; 2022-05-16); removed MW-1.39-notes (1.39.0-wmf.9; 2022-04-25).May 4 2022, 8:00 PM

In T307271#7902806, @ovasileva wrote:

@Edtadros - could you check Edge in production instead as a second verification?

@ovasileva It works in production.

Screen Recording 2022-05-04 at 2.21.20 PM.mov.gif (1×1 px, 1 MB)

Great, resolving

Change 789327 had a related patch set uploaded (by Func; author: Jdrewniak):

[mediawiki/skins/Vector@wmf/1.39.0-wmf.10] [TOC] Remove pointer-events:none on .sidebar-toc-link

https://gerrit.wikimedia.org/r/789327

Merged on the master branch after the train cut, need a backport.

The unclickable ToC problem raised again today for me, when using Microsoft Edge Version 101.0.1210.32 (Official build) (64-bit).

Change 789327 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.39.0-wmf.10] [TOC] Remove pointer-events:none on .sidebar-toc-link

https://gerrit.wikimedia.org/r/789327

Mentioned in SAL (#wikimedia-operations) [2022-05-05T13:30:49Z] <tgr@deploy1002> Synchronized php-1.39.0-wmf.10/skins/Vector/resources: Backport: [[gerrit:789327|[TOC] Remove pointer-events:none on .sidebar-toc-link (T307271)]] (duration: 00m 49s)

Backport deployed.

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.10; 2022-05-02); removed MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 5 2022, 2:00 PM

Reporting that links in the contents sidebar are clickable in Google Chrome version 101.0.4951.54 (Official Build) (64-bit).

Stang removed a subscriber: Stang.May 7 2022, 1:37 AM

	F35103685: Screen Recording 2022-05-04 at 2.21.20 PM.mov.gif
	May 4 2022, 9:22 PM

	F35099980: Screen Recording 2022-05-03 at 6.33.30 PM.mov.gif
	May 4 2022, 1:37 AM

	F35099978: Screen Recording 2022-05-03 at 6.33.56 PM.mov.gif
	May 4 2022, 1:37 AM

Links in the TOC of vector 2022 are not clickable for some Chromium based browsersClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions

Description

QA Steps

QA Results - Beta

Details

Related Objects

Event Timeline

Test Result - Beta

QA Steps

Links in the TOC of vector 2022 are not clickable for some Chromium based browsers
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions