Page MenuHomePhabricator
Create Task
Maniphest T307282

default value of CookieSameSite results in deprecation warning for php 8.1
Open, Needs TriagePublicBUG REPORT
Actions

Description

I saw the following deprecation warning immediately on installed site after switching to 8.1:

Deprecated: strcasecmp(): Passing null to parameter #1 ($string1) of type string is deprecated in .../includes/session/CookieSessionProvider.php on line 99

Using REL1_38

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+3 -3Avoid passing null to strcasecmp(), for PHP 8.1
mediawiki/coreREL1_38+33 -2Address deprecations for php8.1 and REL1_38
mediawiki/coremaster+4 -0Avoid deprecation warnings in PHP 8.1
mediawiki/coreREL1_38+1 -1Avoid deprecation warnings in PHP 8.1
Customize query in gerrit

Event Timeline

MarkAHershberger created this task.Apr 30 2022, 11:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 30 2022, 11:19 PM
MarkAHershberger added a project: PHP 8.1 support.Apr 30 2022, 11:22 PM
gerritbot added a comment.Apr 30 2022, 11:22 PM

Change 787879 had a related patch set uploaded (by MarkAHershberger; author: MarkAHershberger):

[mediawiki/core@REL1_38] Avoid deprecation warnings in PHP 8.1

https://gerrit.wikimedia.org/r/787879

gerritbot added a project: Patch-For-Review.Apr 30 2022, 11:22 PM
gerritbot added a comment.Apr 30 2022, 11:25 PM

Change 787860 had a related patch set uploaded (by MarkAHershberger; author: MarkAHershberger):

[mediawiki/core@master] Avoid deprecation warnings in PHP 8.1

https://gerrit.wikimedia.org/r/787860

gerritbot added a comment.May 1 2022, 3:29 PM

Change 787880 had a related patch set uploaded (by MarkAHershberger; author: MarkAHershberger):

[mediawiki/core@REL1_38] Address deprecations for php8.1 and REL1_38

https://gerrit.wikimedia.org/r/787880

gerritbot added a comment.May 1 2022, 3:30 PM

Change 787879 abandoned by MarkAHershberger:

[mediawiki/core@REL1_38] Avoid deprecation warnings in PHP 8.1

Reason:

https://gerrit.wikimedia.org/r/787879

gerritbot added a comment.May 1 2022, 9:14 PM

Change 787860 abandoned by MarkAHershberger:

[mediawiki/core@master] Avoid deprecation warnings in PHP 8.1

Reason:

https://gerrit.wikimedia.org/r/787860

Aklapper added a project: MediaWiki-Authentication-and-authorization.May 2 2022, 3:58 PM

Assuming this is about MediaWiki Core (please add codebase project tags if possible - thanks!).

gerritbot added a comment.May 15 2022, 10:51 PM

Change 787880 abandoned by Jforrester:

[mediawiki/core@REL1_38] Address deprecations for php8.1 and REL1_38

Reason:

https://gerrit.wikimedia.org/r/787880

Reedy moved this task from Backlog to MediaWiki core on the PHP 8.1 support board.May 21 2022, 8:24 AM
Jdforrester-WMF moved this task from Blocker to Not a blocker on the MW-1.38-release board.Thu, Jun 2, 8:06 PM
gerritbot added a comment.Sat, Jun 11, 9:38 AM

Change 804691 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/core@master] Avoid passing null to strcasecmp(), for PHP 8.1

https://gerrit.wikimedia.org/r/804691

gerritbot added a comment.Sat, Jun 11, 5:11 PM

Change 804691 merged by jenkins-bot:

[mediawiki/core@master] Avoid passing null to strcasecmp(), for PHP 8.1

https://gerrit.wikimedia.org/r/804691

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.16; 2022-06-13).Sat, Jun 11, 6:00 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL