Page MenuHomePhabricator

Deprecated: Implicit conversion from float 0.00029397010803222656 to int loses precision in .../includes/libs/rdbms/database/TransactionManager.php on line 236
Closed, ResolvedPublicBUG REPORT

Description

Testing 1.38rc0 against php 8.1

Ran into this, first, when testing VE. Later edits showed the same without VE.

Event Timeline

partial backtrace:

wfIndexMain( )	.../index.php:46
MediaWiki->run( )	.../index.php:53
MediaWiki->main( )	.../MediaWiki.php:564
MediaWiki->doPreOutputCommit(  )	.../MediaWiki.php:933
MediaWiki::preOutputCommit( )	.../MediaWiki.php:648
Wikimedia\Rdbms\LBFactory->commitPrimaryChanges(  )	.../MediaWiki.php:678
Wikimedia\Rdbms\LBFactory->forEachLBCallMethod(  )	.../LBFactory.php:310
Wikimedia\Rdbms\LBFactorySimple->forEachLB( )	.../LBFactory.php:251
Wikimedia\Rdbms\LBFactory::Wikimedia\Rdbms\{closure:.../includes/libs/rdbms/lbfactory/LBFactory.php:248-250}(  )	.../LBFactorySimple.php:145
Wikimedia\Rdbms\LoadBalancer->approvePrimaryChanges( )	.../LBFactory.php:249
Wikimedia\Rdbms\LoadBalancer->forEachOpenPrimaryConnection(  )	.../LoadBalancer.php:1729
Wikimedia\Rdbms\LoadBalancer->Wikimedia\Rdbms\{closure:.../includes/libs/rdbms/loadbalancer/LoadBalancer.php:1690-1729}( )	.../LoadBalancer.php:2223
Wikimedia\Rdbms\Database->pendingWriteQueryDuration( )	.../LoadBalancer.php:1702
Wikimedia\Rdbms\TransactionManager->pendingWriteQueryDuration( )	.../Database.php:676
Wikimedia\Rdbms\TransactionManager->calculateLastTrxApplyTime( $rtt = 0.00028085708618164 )

The type hint of that function was changed in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/771929 - which is not part of REL1_38

Change 787899 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_38] Simplify TransactionManager::pendingWriteQueryDuration

https://gerrit.wikimedia.org/r/787899

Change 787899 merged by jenkins-bot:

[mediawiki/core@REL1_38] Simplify TransactionManager::pendingWriteQueryDuration

https://gerrit.wikimedia.org/r/787899