Page MenuHomePhabricator

Sticky header disappears within lead sections of certain articles when old table of contents scrolls into view
Closed, ResolvedPublic3 Estimated Story Points

Description

Steps to reproduce

  1. Go to https://de.wikipedia.org/w/index.php?title=Wikipedia:Fragen_zur_Wikipedia or https://en.wikipedia.org/wiki/Barack_Obama

Expected behavior
Sticky header is present consistently upon scroll

Observed behavior
Sticky header disappears when scrolling through the first section


QA Results - Prod

ACStatusDetails
1T307345#7926149

Event Timeline

Jdlrobson subscribed.

Looks like this is an unexpected regression relating to our changes to track scroll to table of contents

When I delete the table of contents placeholder ($('.toclimit-4').remove()) the behaviour corrects itself

Jdlrobson renamed this task from Sticky header disappears within lead sections of certain articles to Sticky header disappears within lead sections of certain articles when old table of contents scrolls into view.May 2 2022, 7:11 PM

Change 789684 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Factor out a separate scroll observer for the TOC A/B test, which should be fired separately from the page title observer used by the sticky header and TOC

https://gerrit.wikimedia.org/r/789684

Change 789691 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Simplify TOC spacing styles/logic by reusing the visible sticky header class

https://gerrit.wikimedia.org/r/789691

bwang removed bwang as the assignee of this task.May 5 2022, 9:27 PM
bwang subscribed.

Change 789684 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Factor out a separate scroll observer for the TOC A/B test, which should be fired separately from the page title observer used by the sticky header and TOC

https://gerrit.wikimedia.org/r/789684

Change 789691 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Simplify TOC spacing styles/logic by reusing the visible sticky header class

https://gerrit.wikimedia.org/r/789691

Change 790443 had a related patch set uploaded (by Clare Ming; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.39.0-wmf.10] Factor out a separate scroll observer for the TOC A/B test, which should be fired separately from the page title observer used by the sticky header and TOC

https://gerrit.wikimedia.org/r/790443

Change 790443 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.39.0-wmf.10] Factor out a separate scroll observer for the TOC A/B test, which should be fired separately from the page title observer used by the sticky header and TOC

https://gerrit.wikimedia.org/r/790443

Mentioned in SAL (#wikimedia-operations) [2022-05-11T20:25:50Z] <cjming@deploy1002> Synchronized php-1.39.0-wmf.10/skins/Vector/resources: Backport: [[gerrit:790443|Factor out a separate scroll observer for the TOC A/B test, which should be fired separately from the page title observer used by the sticky header and TOC (T307952 T307345)]] (duration: 00m 52s)

Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki, dewiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Steps to reproduce
Go to https://de.wikipedia.org/w/index.php?title=Wikipedia:Fragen_zur_Wikipedia or https://en.wikipedia.org/wiki/Barack_Obama
✅ AC1: Sticky header is present consistently upon scroll

Screen Recording 2022-05-12 at 3.47.51 PM.mov.gif (690×850 px, 3 MB)

Screen Recording 2022-05-12 at 3.47.20 PM.mov.gif (690×850 px, 3 MB)