| ovasileva | |
| May 2 2022, 10:32 AM |
| F35137052: Screen Recording 2022-05-12 at 3.47.20 PM.mov.gif | |
| May 12 2022, 10:51 PM |
| F35137051: Screen Recording 2022-05-12 at 3.47.51 PM.mov.gif | |
| May 12 2022, 10:51 PM |
| F35073513: sticky header bug copy.webm | |
| May 2 2022, 10:32 AM |
| F35073512: sticky header bug.webm | |
| May 2 2022, 10:32 AM |
Expected behavior
Sticky header is present consistently upon scroll
Observed behavior
Sticky header disappears when scrolling through the first section
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T307345#7926149 |
Looks like this is an unexpected regression relating to our changes to track scroll to table of contents
When I delete the table of contents placeholder ($('.toclimit-4').remove()) the behaviour corrects itself
Change 789684 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/skins/Vector@master] Factor out a separate scroll observer for the TOC A/B test, which should be fired separately from the page title observer used by the sticky header and TOC
Change 789691 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/skins/Vector@master] Simplify TOC spacing styles/logic by reusing the visible sticky header class
Change 789684 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Factor out a separate scroll observer for the TOC A/B test, which should be fired separately from the page title observer used by the sticky header and TOC
Change 789691 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Simplify TOC spacing styles/logic by reusing the visible sticky header class
Change 790443 had a related patch set uploaded (by Clare Ming; author: Bernard Wang):
[mediawiki/skins/Vector@wmf/1.39.0-wmf.10] Factor out a separate scroll observer for the TOC A/B test, which should be fired separately from the page title observer used by the sticky header and TOC
Change 790443 merged by jenkins-bot:
[mediawiki/skins/Vector@wmf/1.39.0-wmf.10] Factor out a separate scroll observer for the TOC A/B test, which should be fired separately from the page title observer used by the sticky header and TOC
Mentioned in SAL (#wikimedia-operations) [2022-05-11T20:25:50Z] <cjming@deploy1002> Synchronized php-1.39.0-wmf.10/skins/Vector/resources: Backport: [[gerrit:790443|Factor out a separate scroll observer for the TOC A/B test, which should be fired separately from the page title observer used by the sticky header and TOC (T307952 T307345)]] (duration: 00m 52s)
Status: ✅ PASS
Environment: enwiki, dewiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
Steps to reproduce
Go to https://de.wikipedia.org/w/index.php?title=Wikipedia:Fragen_zur_Wikipedia or https://en.wikipedia.org/wiki/Barack_Obama
✅ AC1: Sticky header is present consistently upon scroll
