Page MenuHomePhabricator

Change "AddDonation" route
Closed, ResolvedPublic2 Estimated Story Points

Description

Change building of the the request for the use case - don't use individual setters for payment data (amount, interval, payment type, iban, etc). Instead, build a PaymentCreationRequest and set it.

Remove all branching that checks the payment type of the returned donation (from the use case response). Instead, do the following:

  • if the URL in the response is not null, redirect to it
  • otherwise, redirect to the URL of the confirmation page.

Remove URL generators from the fundraising application repo (if possible, they might still be needed by memberships).

Event Timeline

kai.nissen set the point value for this task to 5.

When https://github.com/wmde/fundraising-application/pull/2499 is merged, https://github.com/wmde/fundraising-application/pull/2495 should be rebased/cherry-picked on top of the current update-payment-context branch. Then the last remaining test (that uses the confirmation page) can be fixed

kai.nissen changed the point value for this task from 5 to 2.Jun 27 2022, 10:22 AM