Page MenuHomePhabricator
Create Task
Maniphest T307506

Address PHP 8.1 job failures on various PHP libs
Closed, ResolvedPublic
Actions

Description

css-sanitizer uses composer-test-package-php72-or-later... Which now includes includes a PHP 8.1 job.

From T307504: Implicit conversion from float 1.2 to int loses precision, PHP 8.1 fails on a few of our libraries.

To check:

[ ] mediawiki/libs/Dodo - Failure: T307618 - https://gerrit.wikimedia.org/r/q/project:mediawiki/libs/Dodo

Details

ProjectBranchLines +/-Subject
integration/configmaster+15 -10Zuul: Use more canonical way to disable php81 jobs from libraries
integration/configmaster+4 -2Skip PHP 8.1 on Dodo and Zest
integration/configmaster+2 -1Skip PHP 8.1 on RemexHtml
integration/configmaster+5 -0Skip composer-package-php81-docker for css-sanitizer
Customize query in gerrit

Related Objects
Search...

Event Timeline

Reedy created this task.May 3 2022, 8:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 3 2022, 8:41 PM
Reedy triaged this task as High priority.May 3 2022, 8:41 PM
gerritbot added a comment.May 3 2022, 9:07 PM

Change 788798 had a related patch set uploaded (by Reedy; author: Reedy):

[integration/config@master] Mark composer-package-php81-docker as non voting for css-sanitizer

https://gerrit.wikimedia.org/r/788798

gerritbot added a project: Patch-For-Review.May 3 2022, 9:07 PM
gerritbot added a comment.May 3 2022, 9:39 PM

Change 788798 merged by jenkins-bot:

[integration/config@master] Skip composer-package-php81-docker for css-sanitizer

https://gerrit.wikimedia.org/r/788798

Maintenance_bot removed a project: Patch-For-Review.May 3 2022, 10:30 PM
Umherirrender updated the task description. (Show Details)May 4 2022, 9:06 PM
Umherirrender updated the task description. (Show Details)May 4 2022, 9:40 PM
gerritbot added a comment.May 4 2022, 9:48 PM

Change 789292 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[avro-php@master] Test CI for php8.1 - T307506

https://gerrit.wikimedia.org/r/789292

gerritbot added a project: Patch-For-Review.May 4 2022, 9:49 PM

Change 789293 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/libs/Minify@master] Test CI for php8.1 - T307506

https://gerrit.wikimedia.org/r/789293

gerritbot added a comment.May 4 2022, 9:49 PM

Change 789294 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/libs/ObjectFactory@master] Test CI for php8.1 - T307506

https://gerrit.wikimedia.org/r/789294

gerritbot added a comment.May 4 2022, 9:49 PM

Change 789295 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[performance/arc-lamp@master] Test CI for php8.1 - T307506

https://gerrit.wikimedia.org/r/789295

gerritbot added a comment.May 4 2022, 9:49 PM

Change 789296 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/tools/phan/PerfCheckPlugin@master] Test CI for php8.1 - T307506

https://gerrit.wikimedia.org/r/789296

gerritbot added a comment.May 4 2022, 9:49 PM

Change 789297 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/tools/phan/SecurityCheckPlugin@master] Test CI for php8.1 - T307506

https://gerrit.wikimedia.org/r/789297

gerritbot added a comment.May 4 2022, 9:49 PM

Change 789298 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/services/jobrunner@master] Test CI for php8.1 - T307506

https://gerrit.wikimedia.org/r/789298

gerritbot added a comment.May 4 2022, 9:50 PM

Change 789299 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[wikimedia/slimapp@master] Test CI for php8.1 - T307506

https://gerrit.wikimedia.org/r/789299

gerritbot added a comment.May 4 2022, 9:50 PM

Change 789300 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/libs/Timestamp@master] Test CI for php8.1 - T307506

https://gerrit.wikimedia.org/r/789300

gerritbot added a comment.May 4 2022, 9:56 PM

Change 789294 abandoned by Umherirrender:

[mediawiki/libs/ObjectFactory@master] Test CI for php8.1 - T307506

Reason:

works

https://gerrit.wikimedia.org/r/789294

gerritbot added a comment.May 4 2022, 9:56 PM

Change 789300 abandoned by Umherirrender:

[mediawiki/libs/Timestamp@master] Test CI for php8.1 - T307506

Reason:

works

https://gerrit.wikimedia.org/r/789300

gerritbot added a comment.May 4 2022, 9:57 PM

Change 789293 abandoned by Umherirrender:

[mediawiki/libs/Minify@master] Test CI for php8.1 - T307506

Reason:

works

https://gerrit.wikimedia.org/r/789293

gerritbot added a comment.May 4 2022, 9:57 PM

Change 789295 abandoned by Umherirrender:

[performance/arc-lamp@master] Test CI for php8.1 - T307506

Reason:

works

https://gerrit.wikimedia.org/r/789295

Umherirrender updated the task description. (Show Details)May 4 2022, 10:13 PM
Umherirrender added a subscriber: Umherirrender.May 4 2022, 10:18 PM

(Sorry for the spam from jenkins/gerrit and phab by rerunning jobs)

Reedy renamed this task from Make PHP 8.1 jobs non voting? (possibly only for css-sanitizer) to Address PHP 8.1 job failures on various PHP libs.May 4 2022, 11:17 PM
Reedy added a project: PHP 8.1 support.
Reedy updated the task description. (Show Details)
gerritbot added a comment.May 10 2022, 7:39 PM

Change 789299 abandoned by Umherirrender:

[wikimedia/slimapp@master] Test CI for php8.1 - T307506

Reason:

Works now

https://gerrit.wikimedia.org/r/789299

Umherirrender removed a project: Patch-For-Review.May 10 2022, 7:42 PM
Umherirrender updated the task description. (Show Details)
gerritbot added a comment.May 10 2022, 7:44 PM

Change 789297 abandoned by Umherirrender:

[mediawiki/tools/phan/SecurityCheckPlugin@master] Test CI for php8.1 - T307506

Reason:

Works now

https://gerrit.wikimedia.org/r/789297

Reedy moved this task from Backlog to Other on the PHP 8.1 support board.May 21 2022, 8:23 AM
Umherirrender removed a subscriber: Umherirrender.Jun 19 2022, 7:31 PM
gerritbot added a comment.Jun 27 2022, 7:24 PM

Change 809000 had a related patch set uploaded (by Reedy; author: Reedy):

[integration/config@master] Skip PHP 8.1 on RemexHtml

https://gerrit.wikimedia.org/r/809000

gerritbot added a project: Patch-For-Review.Jun 27 2022, 7:24 PM
gerritbot added a comment.Jun 27 2022, 7:27 PM

Change 809000 merged by jenkins-bot:

[integration/config@master] Skip PHP 8.1 on RemexHtml

https://gerrit.wikimedia.org/r/809000

Reedy mentioned this in T311451: Re-enable PHP 8.1 CI on css-sanitizer.Jun 27 2022, 7:35 PM
gerritbot added a comment.Jun 27 2022, 9:10 PM

Change 809022 had a related patch set uploaded (by Reedy; author: Reedy):

[integration/config@master] Skip PHP 8.1 on Dodo and Zest

https://gerrit.wikimedia.org/r/809022

gerritbot added a comment.Jun 27 2022, 9:17 PM

Change 809022 merged by jenkins-bot:

[integration/config@master] Skip PHP 8.1 on Dodo and Zest

https://gerrit.wikimedia.org/r/809022

Reedy removed a project: Patch-For-Review.Jul 2 2022, 6:24 PM
Reedy updated the task description. (Show Details)
Jdforrester-WMF updated the task description. (Show Details)Oct 14 2022, 2:15 PM
Jdforrester-WMF moved this task from Other to Wikimedia production on the PHP 8.1 support board.
Jdforrester-WMF added a parent task: T319065: All Wikimedia production extensions and skins must support PHP 8.1.
Jdforrester-WMF added a subtask: T311462: Re-enable PHP 8.1 CI on Dodo.
Jdforrester-WMF added a subtask: T311450: Re-enable PHP 8.1 CI on RemexHTML.
Jdforrester-WMF added a subtask: T311463: Re-enable PHP 8.1 CI on Zest.Oct 14 2022, 2:18 PM
Jdforrester-WMF updated the task description. (Show Details)
gerritbot added a comment.Oct 14 2022, 3:58 PM

Change 842841 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: Use more canonical way to disable php81 jobs from libraries

https://gerrit.wikimedia.org/r/842841

gerritbot added a project: Patch-For-Review.Oct 14 2022, 3:58 PM

Change 842841 merged by jenkins-bot:

[integration/config@master] Zuul: Use more canonical way to disable php81 jobs from libraries

https://gerrit.wikimedia.org/r/842841

Jdforrester-WMF updated the task description. (Show Details)Oct 14 2022, 4:06 PM
Jdforrester-WMF closed subtask T311463: Re-enable PHP 8.1 CI on Zest as Resolved.
Jdforrester-WMF mentioned this in T316078: Make PHP 8.1 voting on development (master) branch of MW ecosystem (core, extensions, skins, libraries).Oct 25 2022, 2:07 PM
Jdforrester-WMF closed subtask T311450: Re-enable PHP 8.1 CI on RemexHTML as Resolved.Oct 31 2022, 3:50 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF closed this task as Resolved.Nov 3 2022, 10:14 PM
Jdforrester-WMF removed a subtask: T311462: Re-enable PHP 8.1 CI on Dodo.
Jdforrester-WMF updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL