Page MenuHomePhabricator
Create Task
Maniphest T307527

Small (but visible) templates shown with the icon meant for invisible templates
Closed, ResolvedPublic
Actions

Assigned To
• ppelberg
Authored By
matmarex
May 3 2022, 9:59 PM
Tags
Referenced Files
F35122441: Screenshot 2022-05-10 at 00.08.18.png
May 9 2022, 11:15 PM
F35122465: Screenshot 2022-05-10 at 00.12.24.png
May 9 2022, 11:15 PM
F35122423: Screenshot 2022-05-10 at 00.03.38.png
May 9 2022, 11:15 PM
F35122481: Screenshot 2022-05-10 at 00.15.01.png
May 9 2022, 11:15 PM
F35122455: Screenshot 2022-05-10 at 00.11.37.png
May 9 2022, 11:15 PM
F35122484: Screenshot 2022-05-10 at 00.15.29.png
May 9 2022, 11:15 PM
F35099171: image.png
May 3 2022, 9:59 PM
Subscribers
Aklapper
EAkinloose
Esanders
Kerry_Raymond
Krinkle
matmarex

Description

Small (but visible) templates are shown with the icon meant for invisible templates, for example {{' "}} (which outputs those two characters with a thin space): https://en.wikipedia.org/wiki/Goldwater_rule#Violations

image.png (189×932 px, 28 KB)

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (776219f4b)mediawiki/extensions/VisualEditormaster+1 -1
Follow-up Ic15dd21f: Fix typo width->heightVisualEditor/VisualEditormaster+1 -1
Update VE core submodule to master (da708802f)mediawiki/extensions/VisualEditormaster+1 -1
Change focusable minimum size from >8x8 to >=10x4VisualEditor/VisualEditormaster+10 -3
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.May 3 2022, 9:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 3 2022, 9:59 PM
Esanders added a comment.May 4 2022, 1:54 PM

Focusable nodes set an arbitrary minimum size of 8x8, this template is 5x16. Previously we also allowed anything that contained text content. This second check was dropped as it failed on text that was wrapped in display:none.

I think it makes sense to have a minimum size requirement event if there is text content, but it should perhaps allow the rectangular dimension of a single glyph.

gerritbot added a comment.May 4 2022, 1:56 PM

Change 789158 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Change focusable minimum size from >8x8 to >=10x4

https://gerrit.wikimedia.org/r/789158

gerritbot added a project: Patch-For-Review.May 4 2022, 1:56 PM
gerritbot added a comment.May 4 2022, 4:04 PM

Change 789158 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Change focusable minimum size from >8x8 to >=10x4

https://gerrit.wikimedia.org/r/789158

DLynch moved this task from Backlog to Done on the VisualEditor-MediaWiki board.May 4 2022, 4:05 PM
DLynch added a project: Editing QA.
Maintenance_bot removed a project: Patch-For-Review.May 4 2022, 4:31 PM
matmarex added a comment.May 8 2022, 10:06 PM

Thanks.

matmarex moved this task from To Triage to Triaged on the VisualEditor board.May 8 2022, 10:07 PM
matmarex added a project: Editing-team (Kanban Board).
gerritbot added a comment.May 8 2022, 10:08 PM

Change 790015 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (da708802f)

https://gerrit.wikimedia.org/r/790015

gerritbot added a project: Patch-For-Review.May 8 2022, 10:08 PM
matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.May 8 2022, 10:09 PM
matmarex removed a project: Patch-For-Review.
gerritbot added a comment.May 8 2022, 10:46 PM

Change 790015 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (da708802f)

https://gerrit.wikimedia.org/r/790015

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 8 2022, 11:00 PM
EAkinloose subscribed.May 9 2022, 11:15 PM

After fix, the icon meant for invisible templates is not displayed - expected behavior
Edit mode:

Screenshot 2022-05-10 at 00.03.38.png (566×1 px, 126 KB)

Screenshot 2022-05-10 at 00.08.18.png (680×1 px, 181 KB)

Read mode:

Screenshot 2022-05-10 at 00.11.37.png (358×1 px, 17 KB)

Before fix:
Edit mode

Screenshot 2022-05-10 at 00.12.24.png (322×2 px, 169 KB)

Screenshot 2022-05-10 at 00.15.29.png (490×1 px, 129 KB)

Read mode:

Screenshot 2022-05-10 at 00.15.01.png (274×1 px, 162 KB)

EAkinloose edited projects, added Verified; removed Editing QA.May 9 2022, 11:16 PM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
Esanders merged a task: T308800: Invisible templates not displaying in Visual Editor.May 20 2022, 12:38 AM
Esanders moved this task from Ready for Sign Off to Ready to Be Worked On on the Editing-team (Kanban Board) board.
Esanders added a subscriber: Kerry_Raymond.

T307527 describes a regression, the {{Use ... English}} templates e.g. on https://en.wikipedia.org/wiki/South_Mackay,_Queensland are no longer visible

gerritbot added a comment.May 20 2022, 12:41 AM

Change 793566 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Follow-up Ic15dd21f: Fix typo width->height

https://gerrit.wikimedia.org/r/793566

gerritbot added a project: Patch-For-Review.May 20 2022, 12:41 AM
Esanders moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.May 20 2022, 12:41 AM
gerritbot added a comment.May 20 2022, 1:01 AM

Change 793566 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Follow-up Ic15dd21f: Fix typo width->height

https://gerrit.wikimedia.org/r/793566

Maintenance_bot removed a project: Patch-For-Review.May 20 2022, 1:30 AM
EAkinloose edited projects, added Editing QA; removed Verified.May 20 2022, 1:38 AM
gerritbot added a comment.May 20 2022, 11:02 AM

Change 793746 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (776219f4b)

https://gerrit.wikimedia.org/r/793746

gerritbot added a project: Patch-For-Review.May 20 2022, 11:02 AM
gerritbot added a comment.May 20 2022, 2:13 PM

Change 793746 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (776219f4b)

https://gerrit.wikimedia.org/r/793746

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.13; 2022-05-23); removed MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 20 2022, 3:00 PM
Esanders added a comment.May 20 2022, 3:12 PM

{{Use Australian English}} visible on https://en.wikipedia.beta.wmflabs.org/wiki/Bluey_(dog)?veaction=edit

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.May 21 2022, 3:44 PM
matmarex removed a project: Patch-For-Review.
EAkinloose added a comment.May 23 2022, 5:02 PM
In T307527#7945028, @Esanders wrote:

{{Use Australian English}} visible on https://en.wikipedia.beta.wmflabs.org/wiki/Bluey_(dog)?veaction=edit

I confirmed this as well as the other small templates. T307527#7915871 remains valid.

EAkinloose edited projects, added Verified; removed Editing QA.May 23 2022, 5:25 PM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
Esanders mentioned this in T309224: Template node invisible in some cases.May 25 2022, 4:39 PM
Krinkle merged a task: T309224: Template node invisible in some cases.May 25 2022, 7:28 PM
Krinkle subscribed.
• ppelberg closed this task as Resolved.Jun 3 2022, 11:20 PM
• ppelberg claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL