Page MenuHomePhabricator

Special:Contributions namespace fields stuck in bad state after navigating back using the browser button
Closed, ResolvedPublic

Description

As reported at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Bug_in_Special:Contributions_-_lost_checkboxes:

If I go to the contribs page for a given user - say Special:Contributions/Redrose64 - open up the "Search for contributions" collapsed box, and select a namespace, I am then offered two more checkboxes: "Invert selection" and "Associated namespace". Whatever I do with those two, if I click on Search, then use my browser's "back" feature and open up the "Search for contributions" collapsed box again, the chosen namespace is still selected, but the two checkboxes are no longer present. To get them back, I need to select a different namespace, then reselect the one that I wanted first time. Firefox 99.0.1, all skins. --Redrose64 🌹 (talk) 20:45, 3 May 2022 (UTC)

Event Timeline

Special:Contributions uses some custom code to implement the checkbox field toggling, and I guess it doesn't listen to some browser events or something. I tried rewriting it in the usual way and it worked fine.

Change 788821 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] SpecialContributions: Use standard method for hiding fields

https://gerrit.wikimedia.org/r/788821

Was anybody able to reproduce this?

Change 788821 merged by jenkins-bot:

[mediawiki/core@master] SpecialContributions: Use standard method for hiding fields

https://gerrit.wikimedia.org/r/788821

matmarex removed a project: Patch-For-Review.

The fix will be deployed to Wikimedia wikis next week, Tuesday–Thursday, per the usual schedule.