Page MenuHomePhabricator
Create Task
Maniphest T307594

Add special_watchlist to possible event_source values on ipinfo_interaction EventLogging schema
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Following T307262: IP Info: Enable on watchlist, an event may now come from Special:Watchlist.

We need to:

Question: should we also add a default case, say unknown, and add this to the schema, to prevent invalid event data being sent if this type of situation happens again? - No, we'd rather not fail silently

Details

SubjectRepoBranchLines +/-
Add event source special_watchlist to ipinfo_interaction schemaschemas/event/secondarymaster+349 -7
Add event source special_watchlistmediawiki/extensions/IPInfomaster+4 -1
Add event source special_watchlist to specialPage casemediawiki/extensions/IPInfomaster+3 -0
Add special_watchlist ipinfo_interaction schemaschemas/event/secondarymaster+4 -1
Customize query in gerrit

Related Objects

Event Timeline

Tchanders created this task.May 4 2022, 3:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 4 2022, 3:19 PM
Tchanders moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.May 4 2022, 3:19 PM
Tchanders mentioned this in T307262: IP Info: Enable on watchlist.
Tchanders updated the task description. (Show Details)May 4 2022, 4:38 PM
Tchanders set the point value for this task to 2.May 4 2022, 4:59 PM
Tchanders edited projects, added Anti-Harassment (AHaT Sprint 7: The Tin Foil Hat); removed Anti-Harassment.
gerritbot added a comment.May 5 2022, 9:32 AM

Change 789568 had a related patch set uploaded (by Steven Sun; author: Steven Sun):

[schemas/event/secondary@master] IPInfo: Add event source special_watchlist and update description

https://gerrit.wikimedia.org/r/789568

gerritbot added a project: Patch-For-Review.May 5 2022, 9:32 AM
• AGueyte claimed this task.May 5 2022, 9:38 AM
• AGueyte moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 7: The Tin Foil Hat) board.
gerritbot added a comment.May 5 2022, 9:58 AM

Change 789573 had a related patch set uploaded (by Steven Sun; author: Steven Sun):

[mediawiki/extensions/IPInfo@master] Add event source special_watchlist

https://gerrit.wikimedia.org/r/789573

gerritbot added a comment.May 5 2022, 10:26 AM

Change 789576 had a related patch set uploaded (by AGueyte; author: AGueyte):

[schemas/event/secondary@master] Add special_watchlist ipinfo_interaction schema

https://gerrit.wikimedia.org/r/789576

gerritbot added a comment.May 5 2022, 10:35 AM

Change 789578 had a related patch set uploaded (by AGueyte; author: AGueyte):

[mediawiki/extensions/IPInfo@master] Add event source special_watchlist to specialPage case

https://gerrit.wikimedia.org/r/789578

• AGueyte moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 7: The Tin Foil Hat) board.May 5 2022, 10:41 AM
gerritbot added a comment.May 5 2022, 1:31 PM

Change 789576 abandoned by AGueyte:

[schemas/event/secondary@master] Add special_watchlist ipinfo_interaction schema

Reason:

Duplicate with a volunteer patch

https://gerrit.wikimedia.org/r/789576

gerritbot added a comment.May 5 2022, 1:31 PM

Change 789578 abandoned by AGueyte:

[mediawiki/extensions/IPInfo@master] Add event source special_watchlist to specialPage case

Reason:

duplicate with a volunteer patch

https://gerrit.wikimedia.org/r/789578

• AGueyte moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 7: The Tin Foil Hat) board.May 5 2022, 1:35 PM
gerritbot added a comment.May 5 2022, 1:35 PM

Change 789568 merged by jenkins-bot:

[schemas/event/secondary@master] Add event source special_watchlist to ipinfo_interaction schema

https://gerrit.wikimedia.org/r/789568

gerritbot added a comment.May 5 2022, 1:35 PM

Change 789573 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Add event source special_watchlist

https://gerrit.wikimedia.org/r/789573

Tchanders reassigned this task from • AGueyte to StevenSun.May 5 2022, 1:38 PM
Tchanders added subscribers: StevenSun, • AGueyte.

Reassigning to @StevenSun - thanks @AGueyte for reviewing this.

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 5 2022, 2:00 PM
dom_walden moved this task from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 7: The Tin Foil Hat) board.May 6 2022, 7:28 AM
dom_walden subscribed.

Here is the JSON we send to the eventlogging server when opening the popup on Special:Watchlist:

{
  "$schema": "/analytics/mediawiki/ipinfo_interaction/1.3.0",
  "event_action": "open_popup",
  "event_context": "page",
  "event_source": "special_watchlist",
  "user_edit_bucket": "1000+ edits",
  "user_groups": "ipblock-exempt|sysop|*|user|autoconfirmed",
  "event_ipinfo_version": "full",
  "meta": {
    "stream": "mediawiki.ipinfo_interaction",
    "domain": "en.wikipedia.beta.wmflabs.org"
  },
  "dt": "2022-05-06T06:40:30.075Z"
}

In case of regressions, I also tested the popup on revision history, recent changes, log and expanding/collapsing the infobox on Special:Contributions. The correct event was sent in the browser and appeared in https://stream-beta.wmflabs.org/v2/ui/#/?streams=mediawiki.ipinfo_interaction.

Test environment: https://en.wikipedia.beta.wmflabs.org IP Info 0.0.0 (17f9ef2) 09:50, 5 May 2022.

• Niharika closed this task as Resolved.Jun 14 2022, 4:59 PM
• Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 7:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL