@RHo could you help confirm the expectation so we can take action on this bug? Thank you.

Change 789311 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Post edit: avoid title overflow for long article names

https://gerrit.wikimedia.org/r/789311

In T307637#7905281, @Sgs wrote:

@RHo could you help confirm the expectation so we can take action on this bug? Thank you.

Yes, confirmed that this was the expectation, thanks for catching that!

In T307637#7906288, @RHo wrote:

In T307637#7905281, @Sgs wrote:

@RHo could you help confirm the expectation so we can take action on this bug? Thank you.

Yes, confirmed that this was the expectation, thanks for catching that!

I think the requirements might be scattered across more phab tasks because the current status quo (with bug) does not match the expectations mentioned in T258021#6469666 for the following reasons:

1. title should be 2 lines, it is 1 now
2. description should be 1 line, it is 2 now
3. extra overflow is handled with ellipsis instead of fade to

This is how it would look with the fix:

Target	current	with patch
Desktop
Mobile

It addresses issues (1) and (2) but leaves (3) to still use ... since I couldn't find an up-to-date figma/zepelin spec.

@mewoph mentioned that we might have different requirements for mobile as well. @RHo could you clarify the expectations for it as well? Thank you.

This is the existing logic we have for the small task card (used in both the post-edit dialog and the mobile summary view of the suggested edits) and there are a few discrepancies which I'm not sure is intentional (I can't find this component in the Growth components Figma)

	Title	Description	Title color	Image
Desktop (post-edit dialog)	1 line	2 lines	Blue
Mobile (post-edit dialog)	2 lines	1 line	Blue
Mobile (suggested edits)	2 lines	1 line	Black

In T307637#7907898, @mewoph wrote:

This is the existing logic we have for the small task card (used in both the post-edit dialog and the mobile summary view of the suggested edits) and there are a few discrepancies which I'm not sure is intentional (I can't find this component in the Growth components Figma)

	Title	Description	Title color	Image
Desktop (post-edit dialog)	1 line	2 lines	Blue
Mobile (post-edit dialog)	2 lines	1 line	Blue
Mobile (suggested edits)	2 lines	1 line	Black

Hi there - apologies for the discrepancies but the title in the post-edit dialog and summary SE card should be Base10. I think this discrepancy may have been due to originally the post-edit dialog summary view of edits sharing the same code as the inspector card for add links article suggestion (for which we do want blue link title).

As to the logic of the title text, the title and wikidata description should be 1-line max for when there is a wikidata description on the article, but if there is no wikidata description, the title can go over 2 lines:

I've since added another example on the Growth components Figma for the module preview here – the file is a work-in-progress so I've not yet added the related post-edit dialog, but hopefully will be completed in coming weeks!

Hi there - apologies for the discrepancies but the title in the post-edit dialog and summary SE card should be Base10. I think this discrepancy may have been due to originally the post-edit dialog summary view of edits sharing the same code as the inspector card for add links article suggestion (for which we do want blue link title).

I added this update to the patch. Note that in the prior implementation there was an active state defined for the title which was darkening a bit the blue color. Maybe we want to keep some visual feedback in the title on this state.

As to the logic of the title text, the title and wikidata description should be 1-line max for when there is a wikidata description on the article, but if there is no wikidata description, the title can go over 2 lines:

Target	current	with patch (has description)	with patch (no description)
Desktop
Mobile

Done. Note that the truncation logic is now the same across platforms as opposite from before.

I've since added another example on the Growth components Figma for the module preview here – the file is a work-in-progress so I've not yet added the related post-edit dialog, but hopefully will be completed in coming weeks!

Great. Thank you!

@RHo we've +2'ed the patch, but there's still a question at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/789311/6/modules/ext.growthExperiments.Homepage.styles/SmallTaskCard.less#74:

	&-title {
		font-weight: bold;
		margin-bottom: 4px;
		color: @wmui-color-base10;
		&:active {
			// FIXME per https://phabricator.wikimedia.org/T307637#7909619 this color
			// is not defined yet
			color: @wmui-color-base10;
		}
	}

when you know what we should change the active style to, please comment here. thanks!

Change 789311 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Post edit: avoid title overflow for long article name

https://gerrit.wikimedia.org/r/789311

Checked in betalabs - the UI matches the screenshots in @Sgs the comment above.

• Mobile

Adding the screenshots for Mobile SE preview:

no description	with description

@RHo - there is also the case when a user selects filters that return zero results - looks ok?